Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage the AWS Batch service-linked role #101

Open
delagoya opened this issue Nov 8, 2024 · 0 comments
Open

Leverage the AWS Batch service-linked role #101

delagoya opened this issue Nov 8, 2024 · 0 comments

Comments

@delagoya
Copy link

delagoya commented Nov 8, 2024

The current metaflow-computation module creates a custom service role.
AWS Batch introduced a service-linked role (SLR) a few years ago, which obviates this need.

The SLR is also a requirement for in-place compute environment updates for an expanded set of compute environment properties. SLRs are created automatically on the first compute environment creation.

There is still a use-case for user-defined service roles, but this is a legacy feature and should be used intentionally.
I propose to simplify the computation submodule to remove the created custom service role, thus defaulting to the SLR, and creating a new variable that allows a user to provide a custom service role that they created outside of the module.

delagoya pushed a commit to delagoya/terraform-aws-metaflow that referenced this issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant