Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating the CertificateARN Cfn template parameter #18

Open
phitoduck opened this issue Oct 16, 2022 · 0 comments
Open

Consider deprecating the CertificateARN Cfn template parameter #18

phitoduck opened this issue Oct 16, 2022 · 0 comments

Comments

@phitoduck
Copy link

Hi there!

Wouldn't it be a nice user experience if you didn't have to manually register an ACM cert for the Metaflow UI? I believe that's possible now.

I believe that AWS CloudFormation directly supports automatically validating ACM certificates. Whereas currently the CloudFormation template requires the user to validate a certificate for the UI themselves and then plug in the ARN, we could deprecate that value and take care of it for them.

The option for automatic validation is documented here:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-certificatemanager-certificate-domainvalidationoption.html

Here is the parameter in the existing template:

https://github.com/outerbounds/metaflow-tools/blob/master/aws/cloudformation/metaflow-cfn-template.yml#L84-L87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant