Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please support fetching other annotations than personal ones #108

Open
jonassmedegaard opened this issue Jun 4, 2024 · 1 comment · May be fixed by #109
Open

please support fetching other annotations than personal ones #108

jonassmedegaard opened this issue Jun 4, 2024 · 1 comment · May be fixed by #109
Labels
enhancement New feature or request

Comments

@jonassmedegaard
Copy link

I do research collaboratively, using hypothes.is.

We do annotations in public, and I would love to be able to use Gooseberry for rendering annotations for the whole group.

I guess Gooseberry somewhere in the code hardcodes the username as a constraint for which annotations to fetch, and I would like to optionally be able to specify additional acct: values.

@jonassmedegaard jonassmedegaard added the enhancement New feature or request label Jun 4, 2024
@Ninjani Ninjani linked a pull request Jun 6, 2024 that will close this issue
1 task
@Ninjani
Copy link
Member

Ninjani commented Jun 6, 2024

Implemented in PR #109, still needs testing though. You should be able to add a list of usernames to your config as hypothesis_users = [] (without the acct: part, and no need to add your own, that's always used) and then get all public annotations from those users as well. Would you be up for some testing? I've changed the tagging and deleting functionality to make sure it doesn't even attempt to modify other people's annotations but still not sure for instance how it works for annotations which are private to a group which you belong to. Also, trying to think how to add a test for this since it necessarily needs another hypothesis account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants