Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ouster support for Apollo? #287

Closed
daohu527 opened this issue Feb 4, 2024 · 7 comments · May be fixed by #290
Closed

Ouster support for Apollo? #287

daohu527 opened this issue Feb 4, 2024 · 7 comments · May be fixed by #290
Assignees
Labels
enhancement New feature or request

Comments

@daohu527
Copy link

daohu527 commented Feb 4, 2024

Is your feature request related to a problem? Please describe.
We want to support ouster for Apollo.

Describe the solution you'd like
We hope that Ouster will provide an SDK, and Apollo will obtain lidar point clouds through interface calls.
Of course there may be more details, such as some configuration files, etc.

Describe alternatives you've considered

Targeted Platform (please complete the following information only if applicable, otherwise dot N/A):

  • Ouster Sensor? [feature only applicable to specific ouster sensor]
  • Ouster Firmware Version? [feature only applicable to specific fw version]
  • Operating System? [Ubuntu 18.04]
  • Machine Architecture? [x86, arm]
@daohu527 daohu527 added the enhancement New feature or request label Feb 4, 2024
@Samahu Samahu self-assigned this Feb 5, 2024
@Samahu
Copy link
Contributor

Samahu commented Feb 5, 2024

Hi @daohu527, thanks for contacting. I haven't looked very closely into Apollo but i I may ask what kind of support you are looking for? What does Apollo require more than the published PointCloud to utilize our Sensors? Like a specific PointCloud format or is it a little more than that?

@daohu527
Copy link
Author

daohu527 commented Feb 6, 2024

Many people in the community need to use Ouster lidar, so we want to integrate Ouster directly into Apollo.

What we expect is that Ouster can provide an SDK to obtain point clouds, and then Apollo will call the API and adapt to Apollo's point cloud message format.

This is very similar to ROS, but each lidar may have some special configurations, so if possible we can write a design document, then I will push forward and integrate the ouster lidar as soon as possible, of course there are better suggestions we can discuss here.

@Samahu
Copy link
Contributor

Samahu commented Feb 8, 2024

@daohu527 Thanks for your feedback. I checked out Apollo's point cloud description and the list of common point type to include it. With minor changes to the Point Cloud Customization Framework, I added the new point type "xyzit" which should work with any of the sensor udp lidar formats (except that the low data profile lacks the intensity channel).

I created a PR #290 that implements Apollo's point type: . Please give it a try and give us your thoughts if this fulfills this requirement.

@daohu527
Copy link
Author

@Samahu Thank you for your quick solution! I'm on vacation recently, I will give you a plan on February 19th

@daohu527
Copy link
Author

@Samahu I checked your pr, but the difference is that Apollo uses cyber instead of ros, so it needs to be redesigned.

I write an design doc about it. To put it simply, lidar sdk provides a callback interface for Apollo registration, and provides data format meta info for raw data. I currently use the PCD format, and then the apollo lidar driver will register the callback and convert the data into Apollo format.

Looking forward to your reply

@Samahu
Copy link
Contributor

Samahu commented Feb 21, 2024

Hi @daohu527 the framework in question is not very popular on my radar. I think for such task that the team behind Apollo's could utilize the main Ouster SDK to carry out the integration.

@Samahu Samahu closed this as completed Feb 21, 2024
@daohu527
Copy link
Author

Thank you for your reply! Can you tell me what aspects you consider? In fact, each Lidar API only needs to provide registration callbacks.

You know we can refer to the current framework for integration, but we would like to get official support so that during the upgrade and iteration process, the quality of these drivers will be more guaranteed. We can do integrated development if possible, but I would like your support, such as reviewing the code and subsequent updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants