Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros parameter to not publish cloud if dropped udp packages #265

Open
ovaag opened this issue Nov 21, 2023 · 1 comment
Open

Ros parameter to not publish cloud if dropped udp packages #265

ovaag opened this issue Nov 21, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ovaag
Copy link
Contributor

ovaag commented Nov 21, 2023

Is your feature request related to a problem? Please describe.
On our robot, the ouster driver sometimes output incomplete pointclouds where less than 32 lidar packets have been used to create the cloud. This leads to our odometry pipeline working on weird looking clouds and producing misleading scanmatching results.
In these cases we'd rather have no data, than to have bad data.

Describe the solution you'd like
A ros parameter that can be altered to tell the driver if you'd like it to not publish the pointcloud if it's not made up of all the expected lidar packages.

Describe alternatives you've considered
Having some node doing filtering directly after ouster driver to detect sudden drops in number of points in cloud.

I'm currently looking into doing this on our fork of ouster-ros, so I was wondering if this is something you would have interest in having upstream as well? If so, do you have strong opinions on how it should be done, or should I just submit the PR, and take it from there?

@ovaag ovaag added the enhancement New feature or request label Nov 21, 2023
@Samahu Samahu self-assigned this Nov 21, 2023
@Samahu
Copy link
Contributor

Samahu commented Nov 21, 2023

It makes total sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants