Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe does not enforce argument order #30

Open
Kuixz opened this issue Aug 16, 2024 · 0 comments
Open

Subscribe does not enforce argument order #30

Kuixz opened this issue Aug 16, 2024 · 0 comments

Comments

@Kuixz
Copy link
Contributor

Kuixz commented Aug 16, 2024

Refer #27

Not sure if this is a bad thing, so I write here.

In its current state the subscribe command in pkg/slack/command.go accepts filters before or after conclusions (e.g. /gha subscribe owner/repo branches:branch1 conclusion1 workflow:workflow1:conclusion2).

Stopping this behaviour is very easy. But I think more flexibility is better. What do you think @cychiuae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant