Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align parsing and serialization of non-key-value with libwebrtc conventions #92

Open
fippo opened this issue Mar 30, 2023 · 0 comments
Open

Align parsing and serialization of non-key-value with libwebrtc conventions #92

fippo opened this issue Mar 30, 2023 · 0 comments
Labels
breakingchange

Comments

@fippo
Copy link
Member

fippo commented Mar 30, 2023

Parsing

a=fmtp:111 96/96

or the infamous telephone-event 0-15
returns

{'96/96': undefined}

libwebrtc went the other way and uses an empty key to signal the use of this syntax here

Fix at next breaking change
fippo added a commit that referenced this issue Mar 30, 2023
@fippo
Document parsing non-key-value fmtp
33ba036 
until #92 gets fixed
@fippo fippo mentioned this issue Mar 30, 2023
Merged
fippo added a commit that referenced this issue Mar 30, 2023
@fippo
Document parsing non-key-value fmtp
a83c24d 
until #92 gets fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breakingchange
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fippo