Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong treatment of video-audio offers #183

Open
fippo opened this issue Sep 25, 2019 · 1 comment
Open

wrong treatment of video-audio offers #183

fippo opened this issue Sep 25, 2019 · 1 comment

Comments

@fippo
Copy link
Member

fippo commented Sep 25, 2019

reported by @dagingaa.
If you call addTrack(audioTrack), addTrack(videoTrack) and then set an offer containing a video mline followed by an audio mline the answer will be wrong. This happens with offers from safari, other browsers
Fiddle with repro data:
https://jsfiddle.net/mu6kcxrw/1/

There is a test for a similar issue here ('keeps the order from the remote offer') but it did not catch this behaviour, possibly due to the assertion being too weak.

@fippo
Copy link
Member Author

fippo commented Sep 25, 2019

seems fixed in master (future-but-will-never-happen-2.x) but not the 1.x version adapter uses :-|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant