Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltx 2.0 #8

Open
sonnyp opened this issue Sep 10, 2015 · 6 comments
Open

ltx 2.0 #8

sonnyp opened this issue Sep 10, 2015 · 6 comments

Comments

@sonnyp
Copy link

sonnyp commented Sep 10, 2015

There are breaking changes related to how to use DOMElement see https://github.com/node-xmpp/ltx/releases/tag/v2.0.0

Also out of curiosity why do you need a DOM compatible API to use ltx?

@sonnyp sonnyp changed the title Beware ltx 2.0 ltx 2.0 Sep 10, 2015
@legastero
Copy link
Contributor

Thanks for the warning!

JXT originally was based on working with DOM elements directly, and only later used ltx. I created a standalone DOMElement shim so I could use ltx without breaking changes, and later contributed that back to ltx itself. That's how DOMElement ended up as an additional class instead of the Element class exposing the DOM API itself.

@sonnyp
Copy link
Author

sonnyp commented Sep 10, 2015

@legastero thanks

@sonnyp sonnyp closed this as completed Sep 10, 2015
@legastero
Copy link
Contributor

Ah, this also means JXT (and by extension https://github.com/otalk/jxt-xmpp) won't work with node-xmpp-core/client/component anymore, because the parser for the core stream class doesn't create elements that expose the DOM accessors.

@sonnyp
Copy link
Author

sonnyp commented Sep 10, 2015

@legastero I want to make node-xmpp-core/client/component/server parser-element interface configurable

I already made StreamParser from node-xmpp-core configurable

@sonnyp sonnyp reopened this Sep 10, 2015
@sonnyp
Copy link
Author

sonnyp commented Sep 11, 2015

@legastero would that work for you?

EDIT oh but you don't use node-xmpp client/server/component right?

@legastero
Copy link
Contributor

That would work, thanks!

I do use node-xmpp-component with jxt-xmpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants