Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not to include false attrs in JSON? #10

Open
sarumjanuch opened this issue Jan 4, 2016 · 2 comments
Open

Why not to include false attrs in JSON? #10

sarumjanuch opened this issue Jan 4, 2016 · 2 comments

Comments

@sarumjanuch
Copy link

https://github.com/otalk/jxt/blob/master/lib/stanza.js#L104

On this line we have: else if (val !== undefined && val !== false && val !== '') , but what if my value is false and i need it?

@watsoncj
Copy link

Ran into this here as well.

Obvious workaround is to use string false.

Would the changes suggested by @sarumjanuch be of interest?

@legastero
Copy link
Contributor

See #11. Once the tests in stanza.io are passing with this change, I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants