-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an interface for collecting exceptions #3
Comments
Do you mean something as simple as the following? public interface ExceptionCollector {
void add(Throwable t);
} |
@sbrannen Yes. But we may want to have the same signature as If you don't feel like |
+1 Is this issue going anywhere? I'm currently investigating how Mockito's VerificationCollector and AssertJ's SoftAssertions could play nicely together, and I think a common interface like this might be part of the solution. |
@kriegfrj, this issue dropped off our radar, but now that you bring it up, I think it's something worth considering. Anyone care to submit a PR to get the ball rolling? |
I made some relevant comments to this issue under assertj/assertj#1459. |
It would be useful to provide an interface that could be implemented by classes like
org.junit.rules.ErrorCollector
. This could be useful for libraries like Truth.We should consider giving the interface a signature compatible with
java.util.function.Consumer
.The text was updated successfully, but these errors were encountered: