Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary fact gathering #2

Open
ninjabong opened this issue Sep 7, 2014 · 1 comment
Open

unnecessary fact gathering #2

ninjabong opened this issue Sep 7, 2014 · 1 comment

Comments

@ninjabong
Copy link
Member

With the new-style of playbook, - include:ing other sub--playbooks it seems extraneous to run fact checking on every included playbook run (for example myne has 12 - include:s) and instead using gather_facts: False in every playbook except the first one.

Might be worth updating configuration.yml with a comment about why it's disabled to explicate that, but again don't want to start mucking things up until I've heard from @rricard.

@ninjabong ninjabong changed the title fact-caching unnecessary fact gathering Sep 7, 2014
@rricard
Copy link
Contributor

rricard commented Sep 16, 2014

gather_facts: False is totally ok to me, we should do that as long as the user doesn't want to deploy on other machines while doing service discovery So, yes we should default it in the example playbook BUT we should let a note saying thatit shouldn't be used in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants