Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker ci support #1061

Closed
PMExtra opened this issue Feb 4, 2018 · 20 comments
Closed

docker ci support #1061

PMExtra opened this issue Feb 4, 2018 · 20 comments
Assignees
Labels
Feature It's a new feature. TransByAI Translated by AI/GPT.
Milestone

Comments

@PMExtra
Copy link

PMExtra commented Feb 4, 2018

I am trying to do SRS's Docker CI.

I hope to receive official recognition, and if possible, I hope to transfer this project to the official organization.

github: https://github.com/PMExtra/docker-srs

dockerhub: https://hub.docker.com/r/pm9551/srs

TRANS_BY_GPT3

@PMExtra
Copy link
Author

PMExtra commented Feb 4, 2018

Discovered that the official team once made a Docker image in SRS 1.0 version, but I wonder why they later abandoned it?

TRANS_BY_GPT3

@winlinvip winlinvip added the Feature It's a new feature. label Feb 24, 2018
@winlinvip winlinvip added this to the srs 3.0 release milestone Feb 24, 2018
@winlinvip
Copy link
Member

winlinvip commented Feb 24, 2018

Mainly because there is no time to maintain multiple projects. Feel free to submit a PR at https://github.com/ossrs/srs-docker.

TRANS_BY_GPT3

@wony-zheng
Copy link

wony-zheng commented Apr 2, 2018

I use Docker to run SRS, but every time I call DVR, the container crashes. SRS is not inherently compatible with Docker, and its restart mode conflicts with Docker.

TRANS_BY_GPT3

@PMExtra
Copy link
Author

PMExtra commented Apr 2, 2018

@wony-zheng Turn off the srs daemon, and then add --restart always to the docker run command

TRANS_BY_GPT3

@PMExtra
Copy link
Author

PMExtra commented Apr 2, 2018

@winlinvip If you plan to do CI, I suggest adding Docker support directly within this project. This way, triggering builds based on branches and tags is the simplest approach. If you use a separate build script to complete the build, you will need to set up a webhook and ensure that the CI platform supports setting environment variables through webhooks, which complicates matters.

TRANS_BY_GPT3

@objnf-dev
Copy link

objnf-dev commented Apr 2, 2018

I submitted a PR, feel free to refer to it.

TRANS_BY_GPT3

@PMExtra
Copy link
Author

PMExtra commented Apr 2, 2018

@zhouweitong3 Thank you for your contribution, but I feel like you have submitted too many things that are unrelated to the core functionality of SRS, even including your own certificate. This seems more like your personal exclusive image rather than an official image for the community users.

Currently, my building method is based on the official Docker images of several large open-source projects, including nginx/redis, and it also supports managing multiple image versions. However, it requires manual maintenance.

image

image

TRANS_BY_GPT3

@objnf-dev
Copy link

objnf-dev commented Apr 2, 2018

Thank you for the feedback~
Actually, that certificate is a sample certificate issued by localhost to localhost, valid until 2099.
The purpose is to test the use of HTTPS.

I still feel that yours is more professional~
I have already starred it~

TRANS_BY_GPT3

@PMExtra
Copy link
Author

PMExtra commented Apr 3, 2018

@zhouweitong3 Generally speaking, Docker images should not include sample certificates. You can refer to the way nginx configures certificates.

TRANS_BY_GPT3

@wony-zheng
Copy link

wony-zheng commented Apr 3, 2018

@PMExtra restart is useless, I tested and found that the previous streaming has already been disconnected and the recording files are also lost. Even if it restarts, it's not what I want for SRS. I have already given up on the docker mode and now using the service mode.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Jul 30, 2018

@PMExtra @zhouweitong3 Can SRS docker submit PR to https://github.com/ossrs/srs-docker? Is this PR ossrs/dev-docker#6 submitted by you?

TRANS_BY_GPT3

@PMExtra
Copy link
Author

PMExtra commented Jul 30, 2018

@winlinvip I haven't submitted a PR yet, and I haven't maintained the version for a while. I'll find some time to work on it soon.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

👍

@PMExtra
Copy link
Author

PMExtra commented Aug 5, 2018

After trying, submitting a pull request is not an appropriate solution because my repository is not a fork of ossrs/srs-docker and has very little similarity to it. Furthermore, my project relies on WebHook to achieve automatic building, and a significant part of its value lies in the Docker Cloud configuration I have made, not just the content in the git project. Therefore, I cannot merge my project into ossrs/srs-docker.

I believe the best approach is to directly add my build script to the ossrs/srs project itself and configure a webhook. This way, we can rely on the release tag of this project to trigger automatic builds, avoiding the need for separate maintenance.

The alternative solution is to transfer the PMExtra/docker-srs project directly to ossrs. However, this would require someone to manually push tags to maintain versions.

The final solution is:
If you insist on using the current build method and are unwilling to use my automated build, then you can copy the source code from my project and modify it yourself. I am willing to give up all rights.

TRANS_BY_GPT3

@PMExtra
Copy link
Author

PMExtra commented Aug 5, 2018

qq20180805-220025 2x

Promote a wave, just maintained the recent version, currently in the queue for building.
Other users who are interested in this PR can go to https://hub.docker.com/r/pm9551/srs/ to use it.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Aug 9, 2018

I will simply shut down srs-docker and then connect it to your project.

TRANS_BY_GPT3

@PMExtra
Copy link
Author

PMExtra commented Aug 9, 2018

Then I will transfer ownership to you, and you can give me a contributor role so that I can continue to participate in maintenance. This would be better.
Also, the current Docker Hub account for publishing images is under my personal name, but I noticed there is an ossrs Docker account. I hope we can use the official account for publishing.
Could you please add me on QQ for convenient and instant communication? My QQ number is 1304445713.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Aug 10, 2018

Sure, I will add you as an owner. You can directly submit it to srs-docker. Please add me on WeChat: winterserver. If you need any other information, you can contact me.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Aug 10, 2018

I have added you as the Owner of https://github.com/ossrs/srs-docker. You can define how to maintain this project on your own.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

Dup to #1595

@winlinvip winlinvip self-assigned this Sep 12, 2021
@winlinvip winlinvip changed the title docker ci 支持 docker ci support Jul 26, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature It's a new feature. TransByAI Translated by AI/GPT.
Projects
None yet
Development

No branches or pull requests

4 participants