-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker ci support #1061
Comments
Discovered that the official team once made a Docker image in SRS 1.0 version, but I wonder why they later abandoned it?
|
Mainly because there is no time to maintain multiple projects. Feel free to submit a PR at https://github.com/ossrs/srs-docker.
|
I use Docker to run SRS, but every time I call DVR, the container crashes. SRS is not inherently compatible with Docker, and its restart mode conflicts with Docker.
|
@wony-zheng Turn off the srs daemon, and then add --restart always to the docker run command
|
@winlinvip If you plan to do CI, I suggest adding Docker support directly within this project. This way, triggering builds based on branches and tags is the simplest approach. If you use a separate build script to complete the build, you will need to set up a webhook and ensure that the CI platform supports setting environment variables through webhooks, which complicates matters.
|
I submitted a PR, feel free to refer to it.
|
@zhouweitong3 Thank you for your contribution, but I feel like you have submitted too many things that are unrelated to the core functionality of SRS, even including your own certificate. This seems more like your personal exclusive image rather than an official image for the community users. Currently, my building method is based on the official Docker images of several large open-source projects, including nginx/redis, and it also supports managing multiple image versions. However, it requires manual maintenance.
|
Thank you for the feedback~ I still feel that yours is more professional~
|
@zhouweitong3 Generally speaking, Docker images should not include sample certificates. You can refer to the way nginx configures certificates.
|
@PMExtra restart is useless, I tested and found that the previous streaming has already been disconnected and the recording files are also lost. Even if it restarts, it's not what I want for SRS. I have already given up on the docker mode and now using the service mode.
|
@PMExtra @zhouweitong3 Can SRS docker submit PR to https://github.com/ossrs/srs-docker? Is this PR ossrs/dev-docker#6 submitted by you?
|
@winlinvip I haven't submitted a PR yet, and I haven't maintained the version for a while. I'll find some time to work on it soon.
|
👍 |
After trying, submitting a pull request is not an appropriate solution because my repository is not a fork of ossrs/srs-docker and has very little similarity to it. Furthermore, my project relies on WebHook to achieve automatic building, and a significant part of its value lies in the Docker Cloud configuration I have made, not just the content in the git project. Therefore, I cannot merge my project into ossrs/srs-docker. I believe the best approach is to directly add my build script to the ossrs/srs project itself and configure a webhook. This way, we can rely on the release tag of this project to trigger automatic builds, avoiding the need for separate maintenance. The alternative solution is to transfer the PMExtra/docker-srs project directly to ossrs. However, this would require someone to manually push tags to maintain versions. The final solution is:
|
Promote a wave, just maintained the recent version, currently in the queue for building.
|
I will simply shut down srs-docker and then connect it to your project.
|
Then I will transfer ownership to you, and you can give me a contributor role so that I can continue to participate in maintenance. This would be better.
|
Sure, I will add you as an owner. You can directly submit it to srs-docker. Please add me on WeChat: winterserver. If you need any other information, you can contact me.
|
I have added you as the Owner of https://github.com/ossrs/srs-docker. You can define how to maintain this project on your own.
|
Dup to #1595 |
I am trying to do SRS's Docker CI.
I hope to receive official recognition, and if possible, I hope to transfer this project to the official organization.
github: https://github.com/PMExtra/docker-srs
dockerhub: https://hub.docker.com/r/pm9551/srs
TRANS_BY_GPT3
The text was updated successfully, but these errors were encountered: