Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for package-feeds pubsub SchemaVer field in Scheduler #48

Open
tom--pollard opened this issue Apr 27, 2021 · 1 comment
Open

Check for package-feeds pubsub SchemaVer field in Scheduler #48

tom--pollard opened this issue Apr 27, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@tom--pollard
Copy link
Contributor

tom--pollard commented Apr 27, 2021

The package-feeds project now validates & versions its package data output against a json schema https://github.com/ossf/package-feeds/blob/main/package.schema.json

The SchemaVer should follow semantic versioning, as such any minor 1.* release should guarantee compatibility for the current Scheduler expectations (Name, Version, Type). Any major version bump could signal incompatability (see ossf/package-feeds#93 for example) as such this value should be checked before blindly accessing the current fields

@oliverchang
Copy link
Contributor

Thanks for the head's up!

@oliverchang oliverchang added the bug Something isn't working label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants