Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Patch release improvement to x/slashing begin block logic #8031

Open
ValarDragon opened this issue Apr 12, 2024 · 0 comments
Open

Comments

@ValarDragon
Copy link
Member

Summary

BeginBlock logic for slashing takes 2-3% of sync time right now, even in v24.
image

We can in a patch release speed this up by:

  • Making signedblocks window not call GetParams. Use passed in params
  • Making a single logger call, not one per validator
  • Cache MinSignedPerWindowInt

That would speedup sync speed by ~.8%.

We may also be able to patch release improve GetMissedBlockBitMapChunk by skipping getting a chunk from state if a validator has 100% uptime and signed the block.

Problem Definition

No response

Proposed Feature

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

1 participant