From c8dc8a54121bbbf2f1fc53f5666fd9219e2e1bd9 Mon Sep 17 00:00:00 2001 From: Arzhel Younsi Date: Mon, 12 May 2025 19:20:40 +0200 Subject: [PATCH 1/4] Brest advertising board conflate on access=yes too So existing advertising=board can have suggestions for extra (more accurate) tags. --- analysers/analyser_merge_advertising_board_FR_brest.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/analysers/analyser_merge_advertising_board_FR_brest.py b/analysers/analyser_merge_advertising_board_FR_brest.py index 021ed4ce2..f410c5148 100644 --- a/analysers/analyser_merge_advertising_board_FR_brest.py +++ b/analysers/analyser_merge_advertising_board_FR_brest.py @@ -46,7 +46,8 @@ def __init__(self, config, logger=None): Conflate( select=Select( types=["nodes", "ways"], - tags={"advertising": "board"}), + tags={"advertising": "board", + "access":"yes"}), conflationDistance=10, mapping=Mapping( static1={"advertising": "board", From 0473abbababf9697278cee5f153416cb17f3924f Mon Sep 17 00:00:00 2001 From: Arzhel Younsi Date: Tue, 13 May 2025 22:02:39 +0200 Subject: [PATCH 2/4] Rollback conflate select, use different self.def_class_ --- .../analyser_merge_advertising_board_FR_brest.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/analysers/analyser_merge_advertising_board_FR_brest.py b/analysers/analyser_merge_advertising_board_FR_brest.py index f410c5148..9eab1ba56 100644 --- a/analysers/analyser_merge_advertising_board_FR_brest.py +++ b/analysers/analyser_merge_advertising_board_FR_brest.py @@ -28,11 +28,11 @@ class analyser_merge_advertising_board_FR_Brest(Analyser_Merge_Point): def __init__(self, config, logger=None): Analyser_Merge_Point.__init__(self, config, logger) self.def_class_missing_official(item=8360, id=1, level=3, tags=['merge', 'public equipment', 'fix:survey', 'fix:picture'], - title=T_('Advertising board not integrated')) + title=T_('Advertising board in OpenData but not in OSM')) + self.def_class_missing_osm(item=7361, id=2, level=3, tags=['merge'], + title=T_('Advertising board in OSM but not in OpenData')) self.def_class_possible_merge(item=8361, id=3, level=3, tags=['merge'], - title=T_('Advertising board integration suggestion')) - self.def_class_update_official(item=8362, id=4, level=3, tags=['merge'], - title=T_('Advertising board update')) + title=T_('Advertising board in both OpenData and OSM, integration suggestion')) self.init( "https://www.data.gouv.fr/fr/datasets/panneaux-dexpression-libre/", "Position des panneaux d'expression libre sur le territoire de Brest métropole.", @@ -46,8 +46,7 @@ def __init__(self, config, logger=None): Conflate( select=Select( types=["nodes", "ways"], - tags={"advertising": "board", - "access":"yes"}), + tags={"advertising": "board"}), conflationDistance=10, mapping=Mapping( static1={"advertising": "board", From f46bcc0c8c38d5588ee51ce5a8ede1939606841a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Rodrigo?= Date: Sat, 17 May 2025 19:08:17 +0200 Subject: [PATCH 3/4] Update analysers/analyser_merge_advertising_board_FR_brest.py --- analysers/analyser_merge_advertising_board_FR_brest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/analysers/analyser_merge_advertising_board_FR_brest.py b/analysers/analyser_merge_advertising_board_FR_brest.py index 9eab1ba56..070283bd5 100644 --- a/analysers/analyser_merge_advertising_board_FR_brest.py +++ b/analysers/analyser_merge_advertising_board_FR_brest.py @@ -28,7 +28,7 @@ class analyser_merge_advertising_board_FR_Brest(Analyser_Merge_Point): def __init__(self, config, logger=None): Analyser_Merge_Point.__init__(self, config, logger) self.def_class_missing_official(item=8360, id=1, level=3, tags=['merge', 'public equipment', 'fix:survey', 'fix:picture'], - title=T_('Advertising board in OpenData but not in OSM')) + title=T_('Advertising board not integrated')) self.def_class_missing_osm(item=7361, id=2, level=3, tags=['merge'], title=T_('Advertising board in OSM but not in OpenData')) self.def_class_possible_merge(item=8361, id=3, level=3, tags=['merge'], From a0c2f3ba2ef84e012e7f4dffb275a1922ef93347 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Rodrigo?= Date: Sat, 17 May 2025 19:08:58 +0200 Subject: [PATCH 4/4] Update analysers/analyser_merge_advertising_board_FR_brest.py --- analysers/analyser_merge_advertising_board_FR_brest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/analysers/analyser_merge_advertising_board_FR_brest.py b/analysers/analyser_merge_advertising_board_FR_brest.py index 070283bd5..3d4f67842 100644 --- a/analysers/analyser_merge_advertising_board_FR_brest.py +++ b/analysers/analyser_merge_advertising_board_FR_brest.py @@ -32,7 +32,7 @@ def __init__(self, config, logger=None): self.def_class_missing_osm(item=7361, id=2, level=3, tags=['merge'], title=T_('Advertising board in OSM but not in OpenData')) self.def_class_possible_merge(item=8361, id=3, level=3, tags=['merge'], - title=T_('Advertising board in both OpenData and OSM, integration suggestion')) + title=T_('Advertising board integration suggestion')) self.init( "https://www.data.gouv.fr/fr/datasets/panneaux-dexpression-libre/", "Position des panneaux d'expression libre sur le territoire de Brest métropole.",