Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Wikimedia images licence parsing #545

Open
dmpr0 opened this issue Oct 17, 2024 · 3 comments
Open

Improve Wikimedia images licence parsing #545

dmpr0 opened this issue Oct 17, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@dmpr0
Copy link
Contributor

dmpr0 commented Oct 17, 2024

Description

We still can find licence in form like Q18199165.

SELECT ?item ?itemLabel ?value WHERE {
  ?item wdt:P2479 ?value .
  SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}
LIMIT 100
@vshcherb vshcherb added this to the 4.9-web milestone Oct 17, 2024
This was referenced Oct 23, 2024
@dmpr0 dmpr0 reopened this Nov 7, 2024
@dmpr0
Copy link
Contributor Author

dmpr0 commented Nov 7, 2024

Review

  • Different or missed data on Android

@dmpr0
Copy link
Contributor Author

dmpr0 commented Nov 14, 2024

Review 2

  • [ ]

@alisa911 Please provide details about changes, and what exactly Android (and iOS in the future) should change in the current implementation.

@alisa911
Copy link
Contributor

alisa911 commented Nov 15, 2024

To use the updated API for retrieving image metadata, you need to:

  • Update the usage of /parse-image-info endpoint.
  • Instead of sending the raw image data in the data parameter, you should now pass the new parameters: imageTitle, pageId, and lang.
  • To work with a list of images, you can use the /parse-images-list-info API. The data parameter includes the title, pageId, and optionally rawData if it is available.
    • Add parameters deviceId and accessToken for user validation when saving raw data to the cache.

It's better to use the API for the list to reduce the number of server requests. Additionally, you can pass the parsed rawData directly from the Android client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants