Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM Live participants: a) no https for credentials b) use oauth or other secure methods #37

Open
ToeBee opened this issue Dec 8, 2016 · 17 comments

Comments

@ToeBee
Copy link

ToeBee commented Dec 8, 2016

The page that allows people to sign up to be OSM live recipients (http://osmand.net/osm_live) asks for OSM user name and password and then transmits it in an unencrypted HTTP post back to osmand.net servers.

This is completely unacceptable.

At the very least the form post should be happening via HTTPS. I can't even use HTTPS if I try because the certificate is self-signed and the SSL virtual host is not configured so all I get is a 404 anyway.

However the real solution is to use OAuth and not ask for peoples passwords at all.

@pnorman
Copy link

pnorman commented Dec 8, 2016

However the real solution is to use OAuth and not ask for peoples passwords at all.

Yes, a third party site shouldn't be asking for passwords. That's what OAuth is for, and examples like this are often cited in why to remove HTTP basic auth.

@ghost
Copy link

ghost commented Dec 9, 2016

Plus 1

@vshcherb
Copy link
Member

No worries we are on the same site, I support this request and feel critical for this. I will try to find a web developer and improve it.

@vshcherb vshcherb changed the title Asking for and transmitting OSM credentials without encryption OSM Live participants: a) no https for credentials b) use oauth or other secure methods Jan 18, 2017
@ghost
Copy link

ghost commented Sep 7, 2017

Any update on this? I'd like to earn some Bitcoins for my mapping but I'm not going to give my OSM password.

@HolgerJeromin
Copy link

@M1dgard you can change your password to a dummy pw, authorize osmand.net and reset the password to a strong one.

@ToeBee
Copy link
Author

ToeBee commented Sep 8, 2017

Well at least the page is being served up via HTTPS now.

@vshcherb
Copy link
Member

vshcherb commented Sep 8, 2017

@HolgerJeromin fully agree, may be we should make a note! We don't try to use OSM credentials though we don't have specialists in web to setup OAuth. Any help is welcome.

@vshcherb vshcherb closed this as completed Sep 8, 2017
@HolgerJeromin
Copy link

@vshcherb did you closed the issue on purpose?

@dbdean
Copy link

dbdean commented Sep 29, 2017

Please reopen this issue. OSMAnd should not be requesting our OpenStreetMap usernames and passwords.

@vshcherb
Copy link
Member

https was implemented.

@dbdean
Copy link

dbdean commented Sep 29, 2017

Ok. Is there an issue I can subscribe to for getting OAuth support up and running? osmandapp/OsmAnd#3457 was closed as a duplicate of this, but was about the OAuth support. Perhaps open that issue again?

@dbdean
Copy link

dbdean commented Sep 29, 2017

In fact, I'd prefer an issue about OAuth being used in the app, as well as, and as distinct from the website.

@HolgerJeromin
Copy link

@dbdean we have currently no oauth issue for the app itself.

@pnorman
Copy link

pnorman commented Sep 29, 2017

https was implemented.

Yes, but that doesn't fix part b, which is about not having give your password to a third-party. This is different than using http basic auth for an editor, because no third parties are involved there.

@vshcherb vshcherb reopened this Oct 1, 2017
@vshcherb
Copy link
Member

a) https - is in place

@vpzomtrrfrt
Copy link

Where is the code for this API? The only file I could find appears to be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants