Skip to content

Commit

Permalink
Merge branch 'release-1.5.0' into stable
Browse files Browse the repository at this point in the history
  • Loading branch information
BertrandGouny committed Feb 19, 2021
2 parents 7dac857 + 1ee0cf7 commit 32eb22c
Show file tree
Hide file tree
Showing 32 changed files with 1,220 additions and 2,322 deletions.
27 changes: 25 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,30 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [1.5.0] - 2021-02-19
50M+ docker pulls 🎉🎉🎉 thanks to all contributors 💕

### Added
- Allowing own replication via LDAP_REPLICATION=own #535. Thanks to @sistason !
- Seeding from internal path is now complete. #361. Thanks to @dbck !

### Changed
- Update openldap 2.4.50 to 2.4.57
- Upgrade baseimage to light-baseimage:1.3.2. Thanks to @heidemn !
- Replace mail.schema for postfix-book.schema #450. Thanks to @vivacarvajalito !
- Replace zarafa.schema for kopano.schema

### Removed
- mmc schemas (dhcp.schema, dnszone.schema, mail.schema, mmc.schema, quota.schema) and radius.schema

### Fixed
- Few small typos #536. Thanks to @timgates42 !
- Out of date api in the using-secrets kubernetes yaml #527. Thanks to @joshuacox !
- Custom ldap file and schema #481. Thanks to @Os-carsun !

## [1.4.0] - 2020-06-15
30M+ docker pulls 🎉🎉🎉 thanks to all contributors 💕

### Added
- Allow setting ports on ldap and ldaps #403. Thanks to @chirauki !
- Address firewall issues on RHEL in README #394. Thanks to @BirkhoffLee !
Expand All @@ -14,7 +36,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Seeding from internal path. #361. Thanks to @dbck !
- Enable openldap uid/gid to be specified at runtime #336. Thanks to @lj020326 !

### Changes
### Changed
- Update openldap 2.4.48 to 2.4.50
- LDAP_TLS_PROTOCOL_MIN is deprecated #432. Thanks to @mettacrawler !
- Better handling of environment variables checks #382. Thanks to @obourdon !
Expand All @@ -27,7 +49,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Added
- Multiarch support

### Changes
### Changed
- Update openldap 2.4.47 to 2.4.48 #247
- Upgrade baseimage to light-baseimage:1.2.0 (debian buster)

Expand Down Expand Up @@ -271,6 +293,7 @@ Environment variable LDAP_REPLICATION_HDB_SYNCPROV changed to LDAP_REPLICATION_D
## [0.10.0] - 2015-03-03
New version initial release, no changelog before this sorry.

[1.5.0]: https://github.com/osixia/docker-openldap/compare/v1.4.0...v1.5.0
[1.4.0]: https://github.com/osixia/docker-openldap/compare/v1.3.0...v1.4.0
[1.3.0]: https://github.com/osixia/docker-openldap/compare/v1.2.5...v1.3.0
[1.2.5]: https://github.com/osixia/docker-openldap/compare/v1.2.4...v1.2.5
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
NAME = osixia/openldap
VERSION = 1.4.0
VERSION = 1.5.0

.PHONY: build build-nocache test tag-latest push push-latest release git-tag-version

Expand Down
62 changes: 35 additions & 27 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[![Docker Stars](https://img.shields.io/docker/stars/osixia/openldap.svg)](https://hub.docker.com/r/osixia/openldap/)
[![Layers](https://images.microbadger.com/badges/image/osixia/openldap.svg)](https://hub.docker.com/r/osixia/openldap/)

Latest release: 1.4.0 - [OpenLDAP 2.4.50](https://www.openldap.org/software/release/changes.html) - [Changelog](CHANGELOG.md) | [Docker Hub](https://hub.docker.com/r/osixia/openldap/) 
Latest release: 1.5.0 - [OpenLDAP 2.4.57](https://www.openldap.org/software/release/changes.html) - [Changelog](CHANGELOG.md) | [Docker Hub](https://hub.docker.com/r/osixia/openldap/) 

**A docker image to run OpenLDAP.**

Expand Down Expand Up @@ -39,7 +39,7 @@ Latest release: 1.4.0 - [OpenLDAP 2.4.50](https://www.openldap.org/software/rele
- [Docker Secrets](#docker-secrets)
- [Make your own image or extend this image](#make-your-own-image-or-extend-this-image)
- [Advanced User Guide](#advanced-user-guide)
- [Extend osixia/openldap:1.4.0 image](#extend-osixiaopenldap140-image)
- [Extend osixia/openldap:1.5.0 image](#extend-osixiaopenldap150-image)
- [Make your own openldap image](#make-your-own-openldap-image)
- [Tests](#tests)
- [Kubernetes](#kubernetes)
Expand All @@ -60,13 +60,13 @@ If you find this image useful here's how you can help:
Run OpenLDAP docker image:

```sh
docker run --name my-openldap-container --detach osixia/openldap:1.4.0
docker run --name my-openldap-container --detach osixia/openldap:1.5.0
```

Do not forget to add the port mapping for both port 389 and 636 if you wish to access the ldap server from another machine.

```sh
docker run -p 389:389 -p 636:636 --name my-openldap-container --detach osixia/openldap:1.4.0
docker run -p 389:389 -p 636:636 --name my-openldap-container --detach osixia/openldap:1.5.0
```

Either command starts a new container with OpenLDAP running inside. Let's make the first search in our LDAP container:
Expand Down Expand Up @@ -109,7 +109,7 @@ docker run \
--env LDAP_ORGANISATION="My Company" \
--env LDAP_DOMAIN="my-company.com" \
--env LDAP_ADMIN_PASSWORD="JonSn0w" \
--detach osixia/openldap:1.4.0
--detach osixia/openldap:1.5.0
```

#### Data persistence
Expand Down Expand Up @@ -153,7 +153,7 @@ Do not edit slapd.conf it's not used. To modify your server configuration use ld
#### Seed ldap database with ldif

This image can load ldif files at startup with either `ldapadd` or `ldapmodify`.
Mount `.ldif` in `/container/service/slapd/assets/config/bootstrap/ldif` directory if you want to overwrite image default boostrap ldif files or in `/container/service/slapd/assets/config/bootstrap/ldif/custom` (recommended) to extend image config.
Mount `.ldif` in `/container/service/slapd/assets/config/bootstrap/ldif` directory if you want to overwrite image default bootstrap ldif files or in `/container/service/slapd/assets/config/bootstrap/ldif/custom` (recommended) to extend image config.

Files containing `changeType:` attributes will be loaded with `ldapmodify`.

Expand All @@ -174,24 +174,24 @@ argument to entrypoint if you don't want to overwrite them.
# single file example:
docker run \
--volume ./bootstrap.ldif:/container/service/slapd/assets/config/bootstrap/ldif/50-bootstrap.ldif \
osixia/openldap:1.4.0 --copy-service
osixia/openldap:1.5.0 --copy-service

# directory example:
docker run \
--volume ./ldif:/container/service/slapd/assets/config/bootstrap/ldif/custom \
osixia/openldap:1.4.0 --copy-service
osixia/openldap:1.5.0 --copy-service
```

#### Seed from internal path

This image can load ldif and schema files at startup from an internal path. This is useful if a continuous integration service mounts automatically the working copy (sources) into a docker service, which has a relation to the ci job.
This image can load ldif and schema files at startup from an internal path. Additionally, certificates can be copied from an internal path. This is useful if a continuous integration service mounts automatically the working copy (sources) into a docker service, which has a relation to the ci job.

For example: Gitlab is not capable of mounting custom paths into docker services of a ci job, but Gitlab automatically mounts the working copy in every service container. So the working copy (sources) are accessible under `/builds` in every services
of a ci job. The path to the working copy can be obtained via `${CI_PROJECT_DIR}`. See also: https://docs.gitlab.com/runner/executors/docker.html#build-directory-in-service

This may also work with other CI services, if they automatically mount the working directory to the services of a ci job like Gitlab ci does.

In order to seed ldif or schema files from internal path you must set the specific environment variable `LDAP_SEED_INTERNAL_LDIF_PATH` and/or `LDAP_SEED_INTERNAL_SCHEMA_PATH`. If set this will copy any *.ldif or *.schema file into the default seeding
In order to seed ldif or schema files from internal path you must set the specific environment variable `LDAP_SEED_INTERNAL_LDIF_PATH` and/or `LDAP_SEED_INTERNAL_SCHEMA_PATH`. If set this will copy any files in the specified directory into the default seeding
directories of this image.

Example variables defined in gitlab-ci.yml:
Expand All @@ -202,6 +202,14 @@ variables:
LDAP_SEED_INTERNAL_SCHEMA_PATH: "${CI_PROJECT_DIR}/docker/openldap/schema"
```
Also, certificates can be used by the internal path. The file, specified in a variable, will be copied in the default certificate directory of this image. If desired, you can use these with the LDAP_TLS_CRT_FILENAME, LDAP_TLS_KEY_FILENAME, LDAP_TLS_CA_CRT_FILENAME and LDAP_TLS_DH_PARAM_FILENAME to set a different filename in the default certificate directory of the image.
variables:
LDAP_SEED_INTERNAL_LDAP_TLS_CRT_FILE: "${CI_PROJECT_DIR}/docker/certificates/certs/cert.pem"
LDAP_SEED_INTERNAL_LDAP_TLS_KEY_FILE: "${CI_PROJECT_DIR}/docker/certificates/certs/key.pem"
LDAP_SEED_INTERNAL_LDAP_TLS_CA_CRT_FILE: "${CI_PROJECT_DIR}/docker/certificates/ca/ca.pem"
LDAP_SEED_INTERNAL_LDAP_TLS_DH_PARAM_FILE: "${CI_PROJECT_DIR}/certificates/dhparam.pem"
### Use an existing ldap database
This can be achieved by mounting host directories as volume.
Expand All @@ -213,7 +221,7 @@ simply mount this directories as a volume to `/var/lib/ldap` and `/etc/ldap/slap
docker run \
--volume /data/slapd/database:/var/lib/ldap \
--volume /data/slapd/config:/etc/ldap/slapd.d \
--detach osixia/openldap:1.4.0
--detach osixia/openldap:1.5.0
```

You can also use data volume containers. Please refer to:
Expand All @@ -235,7 +243,7 @@ If you are looking for a simple solution to administrate your ldap server you ca
By default, TLS is already configured and enabled, certificate is created using container hostname (it can be set by docker run --hostname option eg: ldap.example.org).

```sh
docker run --hostname ldap.my-company.com --detach osixia/openldap:1.4.0
docker run --hostname ldap.my-company.com --detach osixia/openldap:1.5.0
```

#### Use your own certificate
Expand All @@ -249,25 +257,25 @@ docker run \
--env LDAP_TLS_CRT_FILENAME=my-ldap.crt \
--env LDAP_TLS_KEY_FILENAME=my-ldap.key \
--env LDAP_TLS_CA_CRT_FILENAME=the-ca.crt \
--detach osixia/openldap:1.4.0
--detach osixia/openldap:1.5.0
```

Other solutions are available please refer to the [Advanced User Guide](#advanced-user-guide)

#### Disable TLS
Add --env LDAP_TLS=false to the run command:

docker run --env LDAP_TLS=false --detach osixia/openldap:1.4.0
docker run --env LDAP_TLS=false --detach osixia/openldap:1.5.0

### Multi master replication
Quick example, with the default config.

#Create the first ldap server, save the container id in LDAP_CID and get its IP:
LDAP_CID=$(docker run --hostname ldap.example.org --env LDAP_REPLICATION=true --detach osixia/openldap:1.4.0)
LDAP_CID=$(docker run --hostname ldap.example.org --env LDAP_REPLICATION=true --detach osixia/openldap:1.5.0)
LDAP_IP=$(docker inspect -f "{{ .NetworkSettings.IPAddress }}" $LDAP_CID)

#Create the second ldap server, save the container id in LDAP2_CID and get its IP:
LDAP2_CID=$(docker run --hostname ldap2.example.org --env LDAP_REPLICATION=true --detach osixia/openldap:1.4.0)
LDAP2_CID=$(docker run --hostname ldap2.example.org --env LDAP_REPLICATION=true --detach osixia/openldap:1.5.0)
LDAP2_IP=$(docker inspect -f "{{ .NetworkSettings.IPAddress }}" $LDAP2_CID)

#Add the pair "ip hostname" to /etc/hosts on each containers,
Expand Down Expand Up @@ -303,7 +311,7 @@ You may have some problems with mounted files on some systems. The startup scrip

To fix that run the container with `--copy-service` argument :

docker run [your options] osixia/openldap:1.4.0 --copy-service
docker run [your options] osixia/openldap:1.5.0 --copy-service

### Debug

Expand All @@ -313,13 +321,13 @@ Available levels are: `none`, `error`, `warning`, `info`, `debug` and `trace`.
Example command to run the container in `debug` mode:

```sh
docker run --detach osixia/openldap:1.4.0 --loglevel debug
docker run --detach osixia/openldap:1.5.0 --loglevel debug
```

See all command line options:

```sh
docker run osixia/openldap:1.4.0 --help
docker run osixia/openldap:1.5.0 --help
```

## Environment Variables
Expand Down Expand Up @@ -372,7 +380,7 @@ TLS options:
Help: https://www.openldap.org/doc/admin24/tls.html

Replication options:
- **LDAP_REPLICATION**: Add openldap replication capabilities. Defaults to `false`
- **LDAP_REPLICATION**: Add openldap replication capabilities. Possible values : `true`, `false`, `own`. Defaults to `false`. Setting this to `own` allow to provide own replication settings via custom bootstrap ldifs.

- **LDAP_REPLICATION_CONFIG_SYNCPROV**: olcSyncRepl options used for the config database. Without **rid** and **provider** which are automatically added based on LDAP_REPLICATION_HOSTS. Defaults to `binddn="cn=admin,cn=config" bindmethod=simple credentials=$LDAP_CONFIG_PASSWORD searchbase="cn=config" type=refreshAndPersist retry="60 +" timeout=1 starttls=critical`

Expand All @@ -386,14 +394,14 @@ Replication options:

If you want to set this variable at docker run command add the tag `#PYTHON2BASH:` and convert the yaml in python:

docker run --env LDAP_REPLICATION_HOSTS="#PYTHON2BASH:['ldap://ldap.example.org','ldap://ldap2.example.org']" --detach osixia/openldap:1.4.0
docker run --env LDAP_REPLICATION_HOSTS="#PYTHON2BASH:['ldap://ldap.example.org','ldap://ldap2.example.org']" --detach osixia/openldap:1.5.0

To convert yaml to python online: https://yaml-online-parser.appspot.com/

Other environment variables:
- **KEEP_EXISTING_CONFIG**: Do not change the ldap config. Defaults to `false`
- if set to *true* with an existing database, config will remain unchanged. Image tls and replication config will not be run. The container can be started with LDAP_ADMIN_PASSWORD and LDAP_CONFIG_PASSWORD empty or filled with fake data.
- if set to *true* when bootstrapping a new database, bootstap ldif and schema will not be added and tls and replication config will not be run.
- if set to *true* when bootstrapping a new database, bootstrap ldif and schema will not be added and tls and replication config will not be run.

- **LDAP_REMOVE_CONFIG_AFTER_SETUP**: delete config folder after setup. Defaults to `true`
- **LDAP_SSL_HELPER_PREFIX**: ssl-helper environment variables prefix. Defaults to `ldap`, ssl-helper first search config from LDAP_SSL_HELPER_* variables, before SSL_HELPER_* variables.
Expand All @@ -413,7 +421,7 @@ docker run \
--env LDAP_ORGANISATION="My company" \
--env LDAP_DOMAIN="my-company.com" \
--env LDAP_ADMIN_PASSWORD="JonSn0w" \
--detach osixia/openldap:1.4.0
--detach osixia/openldap:1.5.0
```

Be aware that environment variable added in command line will be available at any time
Expand All @@ -427,7 +435,7 @@ For example if your environment files **my-env.yaml** and **my-env.startup.yaml*
```sh
docker run \
--volume /data/ldap/environment:/container/environment/01-custom \
--detach osixia/openldap:1.4.0
--detach osixia/openldap:1.5.0
```

Take care to link your environment files folder to `/container/environment/XX-somedir` (with XX < 99 so they will be processed before default environment files) and not directly to `/container/environment` because this directory contains predefined baseimage environment files to fix container environment (INITRD, LANG, LANGUAGE and LC_CTYPE).
Expand All @@ -437,7 +445,7 @@ Note: the container will try to delete the **\*.startup.yaml** file after the en
```sh
docker run \
--volume /data/ldap/environment/my-env.yaml:/container/environment/01-custom/env.yaml \
--detach osixia/openldap:1.4.0
--detach osixia/openldap:1.5.0
```

#### Docker Secrets
Expand All @@ -463,14 +471,14 @@ This is the best solution if you have a private registry. Please refer to the [A

## Advanced User Guide

### Extend osixia/openldap:1.4.0 image
### Extend osixia/openldap:1.5.0 image

If you need to add your custom TLS certificate, bootstrap config or environment files the easiest way is to extends this image.

Dockerfile example:

```dockerfile
FROM osixia/openldap:1.4.0
FROM osixia/openldap:1.5.0
LABEL maintainer="Your Name <[email protected]>"
ADD bootstrap /container/service/slapd/assets/config/bootstrap
Expand Down
2 changes: 1 addition & 1 deletion example/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '2'
services:
openldap:
image: osixia/openldap:1.4.0
image: osixia/openldap:1.5.0
container_name: openldap
environment:
LDAP_LOG_LEVEL: "256"
Expand Down
2 changes: 1 addition & 1 deletion example/extend-osixia-openldap/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM osixia/openldap:1.4.0
FROM osixia/openldap:1.5.0
MAINTAINER Your Name <[email protected]>

ADD bootstrap /container/service/slapd/assets/config/bootstrap
Expand Down
2 changes: 1 addition & 1 deletion example/kubernetes/simple/ldap-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
spec:
containers:
- name: ldap
image: osixia/openldap:1.4.0
image: osixia/openldap:1.5.0
volumeMounts:
- name: ldap-data
mountPath: /var/lib/ldap
Expand Down
1 change: 1 addition & 0 deletions example/kubernetes/using-secrets/.gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
ldap-secret.yaml
ldap-deployment.yaml
5 changes: 4 additions & 1 deletion example/kubernetes/using-secrets/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ ldap-secret.yaml: example
ENV_STARTUP_YAML=$(shell ${ENV_DIR}/file-to-base64.sh ${ENV_DIR}/my-env.startup.yaml) \
envsubst < ldap-secret.tpl > ldap-secret.yaml

example: environment/my-env.startup.yaml environment/my-env.yaml
example: environment/my-env.startup.yaml environment/my-env.yaml ldap-deployment.yaml

environment/my-env.startup.yaml:
cd environment ; cp my-env.startup.yaml.example my-env.startup.yaml

environment/my-env.yaml:
cd environment ; cp my-env.yaml.example my-env.yaml

ldap-deployment.yaml:
cp ldap-deployment.yaml.example ldap-deployment.yaml
24 changes: 23 additions & 1 deletion example/kubernetes/using-secrets/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,29 @@
# Helm-chart

After setting the variables you can get strange variables like:

https://github.com/osixia/docker-openldap/issues/342

I have found that using this helm chart does not have those issues:

https://github.com/jp-gouin/helm-openldap.git

# Generating ldap-secret.yaml

`make example`

Then edit the yaml files in the environment directory to have the desired paraneters, and then make the secret file:
Then edit the yaml files in the environment directory to have the desired parameters, and then make the secret file:

`make ldap-secret.yaml`

And deploy the secret you just made:

`kubectl apply -f ldap-secret.yaml`

Apply the deployment yaml for ldap in k8s:

`kubectl apply -f ldap-deployment.yaml`

Finally apply the service yaml for ldap in k8s:

`kubectl apply -f ldap-service.yaml`
2 changes: 1 addition & 1 deletion example/kubernetes/using-secrets/gce-statefullset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
spec:
containers:
- name: azaldap
image: osixia/openldap:1.4.0
image: osixia/openldap:1.5.0
imagePullPolicy: IfNotPresent
#command: ["/bin/bash","-c","while [ 1 = 1 ] ; do sleep 1; date; done"]
ports:
Expand Down
Loading

0 comments on commit 32eb22c

Please sign in to comment.