Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save changes on page reload or app crash #166

Open
Aadesh-Baral opened this issue Aug 13, 2023 · 10 comments
Open

Save changes on page reload or app crash #166

Aadesh-Baral opened this issue Aug 13, 2023 · 10 comments
Labels
Feature request New feature or request javascript Pull requests that update Javascript code Priority: critical
Milestone

Comments

@Aadesh-Baral
Copy link
Member

Currently all changes are lost in case of app crash or page reload. We need to save the changes in the local storage so that they can be retrieved.

@Aadesh-Baral Aadesh-Baral added Feature request New feature or request Priority: critical javascript Pull requests that update Javascript code labels Aug 13, 2023
@Aadesh-Baral Aadesh-Baral added this to the 1.2.0 milestone Aug 13, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in OSMLocalizer Aug 13, 2023
@Aadesh-Baral Aadesh-Baral moved this from 🆕 New to 📋 Backlog in OSMLocalizer Aug 13, 2023
@Vayras
Copy link

Vayras commented Aug 14, 2023

hi @Aadesh-Baral I would like to contribute towards this

@Aadesh-Baral
Copy link
Member Author

Go ahead @Vayras

@Vayras
Copy link

Vayras commented Aug 14, 2023

@Aadesh-Baral can you assign me this issue?

@Aadesh-Baral
Copy link
Member Author

Aadesh-Baral commented Aug 14, 2023

Add a alert mentioning there are changes which might be lost before reloading a page.
alert

Also add a modal that allows restoring the unuploaded changes in the editor view just like in iDeditor.
unsaved_changes

@Vayras
Copy link

Vayras commented Aug 14, 2023

Okay only add this or also save the data to local storage?

@Aadesh-Baral
Copy link
Member Author

We need to save the data to local storage to restore changes.

@Vayras
Copy link

Vayras commented Aug 14, 2023

cant login
@Aadesh-Baral the login functionality does not seem to be working for me even on http://127.0.0.1:3000 , can you help me with that ?

@Aadesh-Baral
Copy link
Member Author

Have you setup OAuth2 client in Openstreetmap server?

@Aadesh-Baral
Copy link
Member Author

You can follow this development setup guide:
https://github.com/Aadesh-Baral/OSMLocalizer/blob/master/docs/development-setup.md

@Vayras
Copy link

Vayras commented Aug 14, 2023

@Aadesh-Baral Sorry I forgot about that , thank you for your help

@Vayras Vayras removed their assignment Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New feature or request javascript Pull requests that update Javascript code Priority: critical
Projects
None yet
Development

No branches or pull requests

2 participants