Skip to content

Commit 05d3ba5

Browse files
author
Pietro Vertechi
authored
Revert "support datavalue (JuliaArrays#40)" (JuliaArrays#42)
This reverts commit de7eafb.
1 parent de7eafb commit 05d3ba5

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

src/StructArrays.jl

-3
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ function __init__()
2020
isstringarray(::WeakRefStrings.StringArray) = true
2121
default_array(::Type{T}, d) where {T<:Union{AbstractString, Missing}} = WeakRefStrings.StringArray{T}(d)
2222
end
23-
Requires.@require DataValues="e7dc6d0d-1eca-5fa6-8ad6-5aecde8b7ea5" begin
24-
Base.@pure SkipConstructor(::Type{<:DataValues.DataValue}) = true
25-
end
2623
end
2724

2825
end # module

test/REQUIRE

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
Tables
22
PooledArrays
33
WeakRefStrings
4-
DataValues

test/runtests.jl

-11
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using StructArrays
22
using StructArrays: LazyRow
33
import Tables, PooledArrays, WeakRefStrings
4-
using DataValues: DataValue
54
using Test
65

76
# write your own tests here
@@ -409,13 +408,3 @@ end
409408
@test v.a == [i for i in 1:3, j in 1:4]
410409
@test v.b == [j for i in 1:3, j in 1:4]
411410
end
412-
413-
@testset "datavalues" begin
414-
a = DataValue(2)
415-
b = DataValue{Float64}()
416-
s = StructArray(i for i in (a, b))
417-
@test propertynames(s) == (:hasvalue, :value)
418-
@test s.hasvalue == [true, false]
419-
@test s.value isa Vector{Real}
420-
@test s.value[1] == 2
421-
end

0 commit comments

Comments
 (0)