Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-plane pole and zero plots #1

Open
endolith opened this issue May 14, 2022 · 1 comment
Open

Z-plane pole and zero plots #1

endolith opened this issue May 14, 2022 · 1 comment

Comments

@endolith
Copy link

Referencing matplotlib/matplotlib#22867 (comment)

I have two versions published (not sure which is better) https://gist.github.com/endolith/4625838 https://gist.github.com/endolith/8f202597a663220a6f10#file-pairing-py and just pushed my latest (messy) version here:

https://gist.githubusercontent.com/endolith/98acf9824dbf10a01795/raw/3dd5e41d3c1f98f68cd9ae0e1d9d55856f96ea20/pzplot.py

and function for making plots like this:

notch fdsfdsf

is here:

https://gist.githubusercontent.com/endolith/98acf9824dbf10a01795/raw/3dd5e41d3c1f98f68cd9ae0e1d9d55856f96ea20/helpful_plots.py

If you use it, please hide all my crap commit messages and comments :D I can work on it, too, but no time right now.

Superscripts for multiple poles don't seem to be working anymore, I don't know why.

@oscargus
Copy link
Owner

Sorry for the late reply. Thanks for this! I've seen this code when looking for solutions, but thought I'd write something from scratch to not get into licensing issues. This is my attempt https://github.com/oscargus/mplsignal/blob/main/mplsignal/plane_plots.py although I should really provide some examples... (I have multiple poles/zero subscripts with, at least conceptually, configurable distance, although I can realize some issues in the clustering approach already. Also, my approach was that the user should be able to provide an axis object to make it a bit more general.)

Once I get back to this and am happy with my approach, I will take another look into your and see if there is anything missing etc. I think I got stuck at trying to inherit the Matplotlib color cycler last time. But looking forward to get a bit of free time to actually get it into good enough shape to provide a first release.

(There are also deprecations of the mlab module in Matplotlib likely happening, so this would be a good place to inherit those functions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants