Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename src/ModifyTable.jl to src/GenericCharacter.jl or src/CharacterType.jl #162

Closed
fingolfin opened this issue Sep 23, 2024 · 2 comments · Fixed by #171
Closed

Rename src/ModifyTable.jl to src/GenericCharacter.jl or src/CharacterType.jl #162

fingolfin opened this issue Sep 23, 2024 · 2 comments · Fixed by #171
Assignees
Labels
renaming Things need to be renamed in the code

Comments

@fingolfin
Copy link
Member

... or something like that: almost all function left in it are dealing with generic characters as input.

The one exception is specclassparam!. But I think that should perhaps be moved to src/Deprecations.jl ? Perhaps we first need a replacement, though, in that case might retain ModifyTable.jl a bit longer and "just" move 95% of its content to another file.

This new file for generic characters / character types then could also be the home for function added in PR #157 and possibly some others which currently reside in Show.jl

(We might also wish to split this new file into multiple ones later, dunno, we'll make it up as we go, I guess)

@SoongNoonien
Copy link
Member

Yeah, good idea.

The one exception is specclassparam!. But I think that should perhaps be moved to src/Deprecations.jl? Perhaps we first need a replacement, though,...

We need a better way to deal with the class types in general. Maybe we could add a class type type (of course with a better name). A new object of this type could be created on demand out of the tables data. Ideally without copying too much data.

@fingolfin
Copy link
Member Author

Having a "class type" (or "generic class" ???) type might indeed be a good idea, but the details are unclear ... e.g. how would these interact with "generic characters"

@SoongNoonien SoongNoonien self-assigned this Sep 23, 2024
@SoongNoonien SoongNoonien linked a pull request Sep 23, 2024 that will close this issue
@SoongNoonien SoongNoonien added the renaming Things need to be renamed in the code label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renaming Things need to be renamed in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants