Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions list changed? #158

Closed
fingolfin opened this issue Sep 23, 2024 · 2 comments · Fixed by #155
Closed

Exceptions list changed? #158

fingolfin opened this issue Sep 23, 2024 · 2 comments · Fixed by #155
Labels
bug Something isn't working
Milestone

Comments

@fingolfin
Copy link
Member

While updating the book example test PR #104 I've noticed the following changed. Begun with this setup:

T = genchartab("SL3.n1"); h = T[2] * T[2]; scalar(T[4], h)

Now some time ago, we got this output:

0
With exceptions:
  -2*n1 ∈ (q - 1)ℤ

but this has now changed to the following -- which is equivalent, but clearly not fully simplified, because the first exception includes the second one, which hence is redundant.

0
With exceptions:
  -2*n1 ∈ (q - 1)ℤ
  -n1 ∈ (q - 1)ℤ
@fingolfin
Copy link
Member Author

Ah, only after filing this did I noticed PR #155 which perhaps already addresses this?

@SoongNoonien
Copy link
Member

Yes, #155 addresses this.

@SoongNoonien SoongNoonien linked a pull request Sep 23, 2024 that will close this issue
@SoongNoonien SoongNoonien added the bug Something isn't working label Sep 23, 2024
@fingolfin fingolfin added this to the 0.4.0 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants