From 479e6525d15e1c183bd7640b5fb00af3755d590a Mon Sep 17 00:00:00 2001 From: Achilleas Koutsou Date: Thu, 15 Feb 2024 14:27:27 +0100 Subject: [PATCH] distro: explain why we ignore ntp customization When setting the customizations for the kickstart file, we ignore the ntp server part of the timezone settings. While kickstart does support setting these, our kickstart stage does not. Add a comment for future reference. --- pkg/distro/fedora/images.go | 2 ++ pkg/distro/rhel8/images.go | 2 ++ pkg/distro/rhel9/images.go | 2 ++ 3 files changed, 6 insertions(+) diff --git a/pkg/distro/fedora/images.go b/pkg/distro/fedora/images.go index 1e643cb9fb..c92b9c72f1 100644 --- a/pkg/distro/fedora/images.go +++ b/pkg/distro/fedora/images.go @@ -531,6 +531,8 @@ func iotInstallerImage(workload workload.Workload, img.Groups = users.GroupsFromBP(customizations.GetGroups()) img.Language, img.Keyboard = customizations.GetPrimaryLocale() + // ignore ntp servers - we don't currently support setting these in the + // kickstart though kickstart does support setting them img.Timezone, _ = customizations.GetTimezoneSettings() img.AdditionalAnacondaModules = []string{ diff --git a/pkg/distro/rhel8/images.go b/pkg/distro/rhel8/images.go index 1d48fd2da2..95e3b8d9bf 100644 --- a/pkg/distro/rhel8/images.go +++ b/pkg/distro/rhel8/images.go @@ -443,6 +443,8 @@ func edgeInstallerImage(workload workload.Workload, img.Groups = users.GroupsFromBP(customizations.GetGroups()) img.Language, img.Keyboard = customizations.GetPrimaryLocale() + // ignore ntp servers - we don't currently support setting these in the + // kickstart though kickstart does support setting them img.Timezone, _ = customizations.GetTimezoneSettings() if instCust := customizations.GetInstaller(); instCust != nil { diff --git a/pkg/distro/rhel9/images.go b/pkg/distro/rhel9/images.go index cad1740f5d..36d126b5dd 100644 --- a/pkg/distro/rhel9/images.go +++ b/pkg/distro/rhel9/images.go @@ -391,6 +391,8 @@ func edgeInstallerImage(workload workload.Workload, img.Groups = users.GroupsFromBP(customizations.GetGroups()) img.Language, img.Keyboard = customizations.GetPrimaryLocale() + // ignore ntp servers - we don't currently support setting these in the + // kickstart though kickstart does support setting them img.Timezone, _ = customizations.GetTimezoneSettings() if instCust := customizations.GetInstaller(); instCust != nil {