Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded kernel args #824

Open
ProbstDJakob opened this issue Feb 6, 2025 · 1 comment
Open

Remove hardcoded kernel args #824

ProbstDJakob opened this issue Feb 6, 2025 · 1 comment

Comments

@ProbstDJakob
Copy link

Is there a reason to keep the hardcoded kernel args?

img.KernelOptionsAppend = []string{
"rw",
// TODO: Drop this as we expect kargs to come from the container image,
// xref https://github.com/CentOS/centos-bootc-layered/blob/main/cloud/usr/lib/bootc/install/05-cloud-kargs.toml
"console=tty0",
"console=ttyS0",
}

The rw, at least for me, is not the problem, but the console=* args prevent me from using plymouth. As soon as I remove those args on boot via the grub editor plymouth shows up.

@cgwalters
Copy link
Contributor

Yes agree we should drop them, though in practice we probably should try to move some of it to the base image, as it will mean that default VMs lose consoles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants