Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FocusGained/FocusLost events to avoid showing notification when window has focus #92

Open
osa1 opened this issue Feb 20, 2018 · 0 comments

Comments

@osa1
Copy link
Owner

osa1 commented Feb 20, 2018

The new notification feature is really useful -- however there's one improvement that would be great to see. When I'm already focused on tiny I don't want to see any notifications as the window is already in front of me and I can see everything in the tab bar. We already catch FocusGained and FocusLost events from the terminal, so this is just a matter of implementing a boolean state for whether we have focus or not, and show notifications only when we don't.

One caveat is this won't work when tiny is running inside tmux, so we should probably provide a flag for disabling this feature.

cc @meain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant