Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_different_benchmarks needs sector-specific and scope-specific data #165

Open
MichaelTiemannOSC opened this issue Nov 18, 2022 · 0 comments
Assignees
Labels

Comments

@MichaelTiemannOSC
Copy link
Contributor

When first implemented, the ITR tool assumed companies were reporting only combined S1+S2 data. However, as benchmarks and corporate reporting have evolved, this is no longer meaningful.

Related to #162 we know that OECM works consistently across almost all sectors and requires separately-reported S1, S2, and S3 data. In the case of TPI, some sectors require only S1 data, some require S1 and S2 data. Some require S3 data only, S1 and S3 data, or S1, S2, and S3 data.

test_different_benchmarks should be updated with embedded data that can be properly used by the respective benchmarks being used, i.e., separate S1, S2, and S3 data. We can create XFAIL test cases where limited corp data works with one benchmark and not others.

This should be done either on the template-v2 branch or after template-v2 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants