Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021 actual data disrupts 2021 target values #142

Open
MichaelTiemannOSC opened this issue Sep 10, 2022 · 0 comments
Open

2021 actual data disrupts 2021 target values #142

MichaelTiemannOSC opened this issue Sep 10, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@MichaelTiemannOSC
Copy link
Contributor

When we built the first release of the ITR tool, we didn't have any 2021 data. Now that we are most of the way through 2022, there's lots of 2021 data (but not all 2021 data is reported yet). When we transform our target data projections (base_providers.py:get_company_projected_targets) into a DataFrame, data's that's projected from 2021 to 2050 (because we have no actual data) gets a full row of data. Data that was projected from 2022 to 2050 (because we have actual 2021 data) gets np.nan as a target projection. This one element in the array dis-anchors our CAGR computation and returns a row of np.nan values, instead of a proper calculation of the projection.

One way to fix this is to compute the CAGR only upon finding the first valid index of each row, and trust that we'd never ask for a target value when we have factual data instead. Another way is to punch our actual data into the left side of the target projection. Either way, we need to fix this so users are not forced to ignore intermediate data updates throughout the year.

@MichaelTiemannOSC MichaelTiemannOSC added the bug Something isn't working label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant