Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Guzzle with PSR-18 client in OpenAPI Generator for PHP #309

Open
4 of 5 tasks
taisph opened this issue Dec 1, 2023 · 2 comments
Open
4 of 5 tasks

Replace Guzzle with PSR-18 client in OpenAPI Generator for PHP #309

taisph opened this issue Dec 1, 2023 · 2 comments
Assignees
Labels
feat New feature or request.

Comments

@taisph
Copy link

taisph commented Dec 1, 2023

Preflight checklist

Ory Network Project

No response

Describe your problem

Forcing the use of Guzzle can make integration in third party applications a bit more complex than it needs to be. OpenAPI Generator for PHP supports using PSR-18 compatible clients instead of Guzzle, by specifying library: psr-18 in a reasonably new version of the generator. Since Guzzle is PSR-18 compatible, existing users should be able to keep using Guzzle if they choose to.

Describe your ideal solution

Update the OpenAPI Generator for PHP, add library: psr-18 to the generator config and regenerate PHP libraries. Hopefully nothing breaks but would probably require a major semver bump.

Workarounds or alternatives

None feasible. It is quite complicated to manually build and use the PHP libraries.

Version

ory/client v1.4.0

Additional Context

No response

@taisph taisph added the feat New feature or request. label Dec 1, 2023
@aeneasr
Copy link
Member

aeneasr commented Jul 8, 2024

This makes sense to me!

@aeneasr
Copy link
Member

aeneasr commented Jul 8, 2024

Unfortunately, PSR-18 is still in beta support which probably means that it's broken for template generation. I think we'll wait until it is officially released!

@aeneasr aeneasr self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants