Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): update tab html structure and classes #1120

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Nov 18, 2024

Fixes #1127

Proposed Changes

  • remove navitem from tabs
  • rename nav with tablist
  • add tag to tabs component

@mlmoravek mlmoravek added breaking Breaking changes a11y Accessibility labels Nov 18, 2024
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 8cb6447
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/675ff85fc388260008240570
😎 Deploy Preview https://deploy-preview-1120--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek changed the title feat(tabs): update tab html structure (a11y) feat(tabs): update tab html structure and classes Nov 18, 2024
@mlmoravek mlmoravek added the refactoring This involves some refactoring of existing code. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y Tab component Issues
1 participant