Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could this Plugin respect the Manifest File #423

Open
Hanmac opened this issue Jan 7, 2025 · 3 comments
Open

Could this Plugin respect the Manifest File #423

Hanmac opened this issue Jan 7, 2025 · 3 comments

Comments

@Hanmac
Copy link

Hanmac commented Jan 7, 2025

I added Add-Opens to the Manifest file, but so when i start the jar, it works

bit launch4j currently doesn't respect that.

is there a way to fix that, or do i need the add-opens params in opt?

@lukaszlenart
Copy link
Collaborator

I would suggest ti use opt

@Hanmac
Copy link
Author

Hanmac commented Jan 7, 2025

I would suggest ti use opt

Yeah, but we recently removed the Add-opens from the run scripts in favor of AddOpens in the Manifest File

So it would be great if we could do it in one place instead of multiple

Hanmac added a commit to Card-Forge/forge that referenced this issue Jan 7, 2025
Fix AddOpen for launch4j Exe until orphan-oss/launch4j-maven-plugin#423 finds something better
@lukaszlenart
Copy link
Collaborator

The problem is the plugin is just a wrapper around Launch4j - it can only do as much as the tool can do

Hanmac added a commit to neoFuzz/forge that referenced this issue Jan 8, 2025
Fix AddOpen for launch4j Exe until orphan-oss/launch4j-maven-plugin#423 finds something better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants