Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move transactor implementations to "driver" implementations #26

Open
tyler-sommer opened this issue Dec 23, 2013 · 1 comment
Open

Move transactor implementations to "driver" implementations #26

tyler-sommer opened this issue Dec 23, 2013 · 1 comment

Comments

@tyler-sommer
Copy link
Member

Many apis offer integrations deeper than just processing credit cards. We should genericize the transactor implementations so we can more simply implement additional methods.

This might allow for simpler integration with "token creation" (which falls outside of processing a transaction many times, so integrating directly with a transactor is a bit strange)

@tyler-sommer
Copy link
Member Author

This problem shows its face in NMI. The AchTransactor is different from the CardTransactor (though the former inherits from the latter) which causes a really wacky dependency chain.

Alternatively, an NMI adapter could be used that generically interacts with NMI, and then transactors become thin wrappers instead of the huge behemoths they are currently. Following, we could move validation to external classes, further separating concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant