The state of thread #62
Pinned
caffeine-addictt
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Along with thread v1.0.0, we have received some suggestions and criticisms.
This post will address them and serve as an outline for how thread will change going forward.
(Please note that the following is not a 1v1 abstract)
Suggestions
1. We should conform to PEP8
Originally we went with 2 space instead of 4 space linting configuration. This was just a personal preference coming from a lua/javascript background. Python operates on indentation levels and as long as we use consistent indentation of 2 spaces, it really does not matter.
However, as thread grows and matures, we need to make contributing to thread easier and more developer friendly. As such, thread will conform to PEP8.
2. We should change our package name
There are 2 main arguments to this:
thread
is too generic a name and makes it hard to search_thread
module which may be confused forthread
When thread was first released on PyPI, I was not aware of the
_thread
built-in module and admittedly, thread is quite the generic name. It is unfortunate that I was not able to catch this earlier and I'm grateful for this being raised.At present, we are looking for a new name before we make a change.
We welcome naming suggestions.
3. We should change Parallel to Concurrent
In hindsight, this should have been caught from the very start and we apologize for any misconceptions regarding the behavior of
thread.ParallelProcessing
. This was already documented in our docs.As this will be a breaking change as
thread.ParallelProcessing
turns tothread.ConcurrentProcessing
, this change will only be present in the new package v1.0.0.Conclusion
Thank you for all the suggestions!
It is only with your help we can make thread better and better! ❤️
As an extra note, please remain respectful and kind to everyone as outlined in our Code of Conduct
Improving thread
in parallelconcurrently. 😉Beta Was this translation helpful? Give feedback.
All reactions