Replace Set object with Map object #34
Replies: 2 comments
-
I've fixed some tests in the branch (still in WIP). I also did some benchmarks. feat/occurrences-sort benchmark (replaced 'cause checkout on the wrong branch): main benchmark I think this implementation can work properly, it doesn't have a big impact on indexing or searching performance, and also could bring an extension toward the functionality that will be able to be performed by Lyra. For example, we can implement a |
Beta Was this translation helpful? Give feedback.
-
@mateonunez as wrote in https://github.com/nearform/lyra/discussions/56, we had to remove all the |
Beta Was this translation helpful? Give feedback.
-
I was working on #12 and #13. I stashed my code a lot of times looking to keep the same architecture of inserted documents. So hard or stressful for Lyra.
I created a new architecture for inserted documents, replacing the
Set
with aMap<string, number>
(where the number could be replaced with a typed object that will contain metadata).The tests are awesome:
main branch:
with new implementations:
This could be an idea to implement more metadata when a document is indexed.
I also created a branch (in WIP and breaking in some cases) to show how could it work.
Beta Was this translation helpful? Give feedback.
All reactions