[Process] Assignee & Verified

[auniverseaway]

We've gotten feedback that teams want to be in control of when a verified label is added to a given PR.

As mentioned in the Milo developer wiki, the verified label indicates a PR has been verified by a human as meeting the criteria of acceptance given in JIRA ticket. The verified label + two approvals typically means a PR is ready to be merged.

Historically, we have leaned on the Milo community and self-appointed SMEs to add this verified label. We have also leaned on Milo core to validate there are no breaking changes for our growing ecosystem of consumers.

Moving forward, we are asking the community to "assign" the PR to an individual. This individual is responsible for verifying the PR. A PR should not be merged until the assignee of the PR has marked the PR as either trivial or verified.

I want to stress this individual should not always be a QE. We still want SMEs of a given feature to be responsible for verifying a given feature or fix.

Let me know your thoughts.

[honstar]

I think we should review the proposed process and start enforcing this more. In reality, no one really cares for applying the label (including myself) apart from a few. With a growing milo engineering community, we should probably maintain a list of SMEs to whom a PR can be assigned to.

[AddumOne]

Any idea where that list of SMEs should live and who can help build it out?

[TsayAdobe]

After a pull request is submitted, it can be unclear who is responsible for the next steps in the process. To streamline the process and reduce confusion, I suggest using the Labels and Assignees fields to indicate the status of the pull request and who is responsible for each step. This will help ensure that everyone involved in the process knows what they need to do, and that the pull request moves forward efficiently.