4.1.0.beta New features and fixes

[seb5g]

What's Changed

• make sure the averaging within daq_viewer is applied when using daq_scan by @seb5g in make sure the averaging within daq_viewer is applied when using daq_scan #152
• Scan close by @seb5g in Scan close #155
• close properly the parent widget (mainwindow) by @seb5g in close properly the parent widget (mainwindow) #156
• make sure one can now use SpecialSlicerData to set part of a dataobject by @seb5g in make sure one can now use SpecialSlicerData to set part of a dataobject #158
• replacing the dwa "origin" by the control module's title by @seb5g in replacing the dwa "origin" by the control module's title #160
• make sure the total dim included nav axes does not exceed 2D by @seb5g in make sure the total dim included nav axes does not exceed 2D #161
• Add plugin package name to documentation by @bmoneke in Add plugin package name to documentation #162
• Fix node exporters by @seb5g in Fix node exporters #163
• redefines the Vertical label class by @seb5g in redefines the Vertical label class #165
• reverting to using pyqtgraph stuff (using the actual PR#2850 in pyqtg… by @seb5g in reverting to using pyqtgraph stuff (using the actual PR#2850 in pyqtg… #166
• make sure one can resize the header of the parametertree by @seb5g in make sure one can resize the header of the parametertree #167
• publishing dedicated doc on the use/methods to deal with axis in an actuator by @seb5g in publishing dedicated doc on the use/methods to deal with axis in an actuator #171
• Update instrument_plugins.rst by @bmoneke in Update instrument_plugins.rst #164
• Fix 168 threading problems by @bmoneke in Fix 168 threading problems #174
• Documentation for Linux installation by @Ashwolaa in Documentation for Linux installation  #182
• TCP/IP for PyMoDAQ4 - Serialization/Deserialization by @seb5g in TCP/IP for PyMoDAQ4 - Serialization/Deserialization #183
• updated the tcp/ip communication documentation by @seb5g in updated the tcp/ip communication documentation #184
• Deepcopy of dte to prevent change of axis indices by daq_scan by @rgeneaux in Deepcopy of dte to prevent change of axis indices by daq_scan #178
• adds overlay into 1D dataviewer by @seb5g in adds overlay into 1D dataviewer #186
• Update installation.rst by @Ashwolaa in Update installation.rst #191

New Contributors

• @bmoneke made their first contribution in Add plugin package name to documentation #162
• @Ashwolaa made their first contribution in Documentation for Linux installation  #182

Full Changelog: 4.0.8...4.1.0.beta

---

This discussion was created from the release 4.1.0.beta New features and fixes.

[seb5g]

I prepared a new branch called 4.1.0 (for the futur release) to be tested (together with beta release 4.1.0.beta). It means that PR related to bug fixes of its new features will be pushed on this branch, while we keep pymodaq_dev for more new functionnalities. You have then 2 possibilities: either install from the 4.1.0 branch or from the beta release: pip install pymodaq==4.1.0.beta . If there are things to discuss about it there is a discussion on the subject.

[quantumm]

Hi,
I just installed the beta release on a fresh environment with python 3.10 and pyqt5 on Windows 10. When I try to launch a daq_move i get this error:

(pmd4beta) C:\Users\attose10\tmp\pymodaq_plugins_lecroy>daq_move
Traceback (most recent call last):
File "C:\Users\attose10\Anaconda3\envs\pmd4beta\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Users\attose10\Anaconda3\envs\pmd4beta\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "C:\Users\attose10\Anaconda3\envs\pmd4beta\Scripts\daq_move.exe_main.py", line 4, in
File "C:\Users\attose10\Anaconda3\envs\pmd4beta\lib\site-packages\pymodaq\control_modules\daq_move.py", line 23, in
from pymodaq.control_modules.utils import ControlModule
File "C:\Users\attose10\Anaconda3\envs\pmd4beta\lib\site-packages\pymodaq\control_modules\utils.py", line 64, in
raise DetectorError('No installed Detector')
pymodaq.utils.exceptions.DetectorError: No installed Detector

[BenediktBurger]

I think previously the preset could not load, unless there is a detector, maybe there was this error check added, which is also executed in this run_module_as_main.

[seb5g]

This is due to a modification of the pymodaq_plugins_mock package I recently modified. The pre-release version of pymodaq cannot see its instruments anymore

It is due to the new features layout applied to plugins:

These allows to precisely define which feature a plugin is exposing. Under the hood it creates specific entry points that pymodaq can look at. In previous plugin version, the entry point was: pymodaq.plugins which is now replaced by pymodaq.instruments. The pymodaq_dev branch is taking this into account but not the pre-release version.

To solve this, I just published a patch to pymodaq_plugins_mock to still publish an entry point in the form pymodaq.plugins but actually one has to modifiy the method used by pymodaq to fetch entry points in the pre-release code (or its branch)

[rgeneaux]

I see that for instance v1.1.0 of https://github.com/PyMoDAQ/pymodaq_plugins_physik_instrumente has the same issue.
Should we add the line
else: entrypoints['pymodaq.plugins'] = f'{SHORT_PLUGIN_NAME} = {PLUGIN_NAME}' # for backcompatibility
to all plugins to ensure backcompatibility?

[seb5g]

Actually, I'd like to hear you opinion. Due to the intense development activity following the pymodaq days and the ANF, I think we should postpone the release for a time when there will be less development activity, probably in a few month. what do you think?

[BenediktBurger]

As there are no test options, it is good to have the beta release for some time.
Maybe some bug fixes (like the threading issue) could be back ported to a 4.0.9 patch release

[seb5g]

yes but how can we disentangle the patch contributions from the feature contribution as they have already been merged into pymodaq_dev...
What do you mean there are no test?

[rgeneaux]

I think that there are a lot of changes in the 4.1.0 that need to be tested by several of us! The actual release will have to wait before we decide it feels stable enough - hard to say if this will be in a few month or before that. But I'd say that we should focus on bug fixing rather than developing new features, definitely.

[seb5g]

For this I think we should wait and include the things we are working on at the moment also. I'm working in the lab with pymodaq_dev branch so should be soon aware of issues... I'll let you know when development slows down, we'll do another pre-release at that time

[seb5g]

We could also apply a patch to the current pymodaq latest release to deal with that. We would only have to do it once. Le mar. 7 nov. 2023 à 19:10, rgeneaux ***@***.***> a écrit :

…

I see that for instance v1.1.0 of https://github.com/PyMoDAQ/pymodaq_plugins_physik_instrumente has the same issue. Should we add the line else: entrypoints['pymodaq.plugins'] = f'{SHORT_PLUGIN_NAME} = {PLUGIN_NAME}' # for backcompatibility to all plugins to ensure backcompatibility? — Reply to this email directly, view it on GitHub <#195 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSNYI3AI2QJGBLW7C2UIKTYDJ2QPAVCNFSM6AAAAAA6ZLINRWVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TKMBSGA2DS> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[rgeneaux]

I went with
discovered_plugins = get_entrypoints(group='pymodaq.instruments') + get_entrypoints(group='pymodaq.plugins')
(line 607 of daq_utils)
which seems to do the job, except that Mock now appears twice with your patch!

[seb5g]

that's the idea, but I already patched it in the pymodaq_dev branch, I will just use that. Your solution is actually buggy with python 3.8 because they changed the entry point API in between ... I will do the patch, publish a release, remove the patch in the mock and we should be good for this...

[seb5g]

alright it is done:

• pymodaq 4.0.9 is released (with correct entry point selection)
• pymodaq_plugins_mock is back without the patch

[seb5g]

Alright....
The plugin_manager actually needs the info about all the plugins that are installed. Like this it will move the installed plugins into the uninstallable list... with the new fetaure it's not working anymore...

I therefore ask of you all to keep in the setup.py a generic entry point: 'pymodaq.plugins' to advertise python about the fact there is a plugin (we don't know its features but for this we use the other entry points):

so make sure to keep this line in your setup.py:

entrypoints['pymodaq.plugins'] = f'{SHORT_PLUGIN_NAME} = {PLUGIN_NAME}'  # generic plugin, usefull for the plugin manager

Thansk and sorry for the back and forth micmac...