Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error when viewing a citation node #210

Open
egh opened this issue Jan 29, 2022 · 2 comments
Open

[BUG] Error when viewing a citation node #210

egh opened this issue Jan 29, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@egh
Copy link
Contributor

egh commented Jan 29, 2022

Describe the bug
When viewing a citation node, I see a 500 error from the servlet.

To Reproduce
Which specific things did you do which lead to said bug? E.g. what did you click, which commands did you call, etc.

  1. Go to any citation node
  2. Click on it
  3. View the sidebar
  4. See error

Expected behavior
Ideally, I would see a citation but that doesn't seem to be implemented in org-roam. Since that isn't possible, I should see no text.

Screenshots
image

What browser were you using?
Firefox

Additional context
I broke this with my PR #203 . I know how to fix it, but if I return an empty string from the servlet, the text in the sidebar does not update, I think because of this line. I'm more familiar with elisp than typescript, so I'm not sure what to do here. I can return a non-empty string (e.g. " ") from the servlet to force updating, but that feels hacky. I'd prefer to force an update in the sidebar in typescript even when the orgtext is empty.

@egh egh added the bug Something isn't working label Jan 29, 2022
@rasendubi
Copy link
Contributor

rasendubi commented Jan 29, 2022 via email

@egh
Copy link
Contributor Author

egh commented Jan 29, 2022

@rasendubi Thanks for the suggestion! You are correct, but I was wrong: that is not where the text is updated, from what I can tell. I believe #211 will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants