Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide actions when they're not available in orb-note-actions #52

Open
zaeph opened this issue May 17, 2020 · 3 comments
Open

Hide actions when they're not available in orb-note-actions #52

zaeph opened this issue May 17, 2020 · 3 comments
Assignees
Labels
1. enhancement New feature or request

Comments

@zaeph
Copy link
Member

zaeph commented May 17, 2020

It might be better to hide the actions which are not available with the current file when running orb-note-actions.

For instance, if a file does not have a PDF, it should probably not show you the option. Another option might be to change the completion-string for that action to something that indicates that a PDF is not present.

@zaeph zaeph added the 1. enhancement New feature or request label May 17, 2020
@zaeph zaeph self-assigned this May 17, 2020
@j-steinbach
Copy link

I believe that from a user-design perspective, the unavailable options should be "greyed out" out.

Otherwise there is the danger that new/unexperienced users will not know that there is something missing and will never take steps to "fix" the issue.


Damn, Github issues are a great way to procrastinate..

@myshevchuk
Copy link
Member

I believe that from a user-design perspective, the unavailable options should be "greyed out" out.

That's a good point about new users and it would be nice to have these actions "greyed out", but I'm not sure how to achieve this consistently with all the supported completion engines - Helm, Ivy, Ido, Hydra and native completion. Probably, the solution will be to fire an informative message once the unavailable action is chosen. Or to modify the action name with something like "action name (unavailable)"

@myshevchuk
Copy link
Member

Do not grey out Open PDF, suggest to download PDF instead. See #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants