Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: #696

Closed
cankoman opened this issue Jun 17, 2024 · 3 comments
Closed

[Bug]: #696

cankoman opened this issue Jun 17, 2024 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@cankoman
Copy link

cankoman commented Jun 17, 2024

Expected Behavior

I have 3 categories in the preferences modal (necessary, analytics and marketing). Under necessary there are two, under analytics one service and under marketing 3 services.
When I click on "accept all", all categories and services are saved correctly and set in the json.
When the page is reloaded and the preferences modal is opened again via a button, all categories and services are correctly set to "On". If "Save preferences" is now clicked, all categories and services have to be saved as before and should be under "acceptedCategories" AND "acceptedServices".``

Current Behavior

I have 3 categories in the preferences modal (necessary, analytics and marketing). Under necessary there are two, under analytics one service and under marketing 3 services.
When I click on "accept all", all categories and services are saved correctly and set in the json (screenshot 1).
When the page is reloaded and the preferences modal is opened again via a button, all categories and services are correctly set to "On". If "Save preferences" is now clicked (screenshot 2), all categories are correctly saved to "On", but the services are set to "Off".
all services, except for those under "necessary", will end up under "rejectedServices"!

Screenshot1
Screenshot2

Steps to reproduce

  1. open Preferences Modal -> click on "accept all"
  2. reload the page
  3. open Preferences Modal again -> click on "Save preferences"
  4. open Preferences Modal and check the services (were set incorrectly)

Proposed fix or additional info.

No response

Version

3.0.1

On which browser do you see the issue?

Firefox, Chrome

@cankoman cankoman added the bug Something isn't working label Jun 17, 2024
@github-actions github-actions bot added the triage yet to be reviewed label Jun 17, 2024
@peaemaye
Copy link
Contributor

This sounds like the same bug I reported as #700. I've submitted a PR with a fix here: #701

@cankoman
Copy link
Author

cankoman commented Jul 9, 2024

Thank you @peaemaye!

@orestbida orestbida removed the triage yet to be reviewed label Aug 12, 2024
@orestbida orestbida added this to the v3.1.0 milestone Aug 12, 2024
@orestbida
Copy link
Owner

Should be fixed by #701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants