Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to set accessible names #689

Closed
basterrika opened this issue Jun 1, 2024 · 4 comments
Closed

Add options to set accessible names #689

basterrika opened this issue Jun 1, 2024 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@basterrika
Copy link

Description

When using the library, PageSpeed Insights returns the error 'Elements with role=“dialog” or role=“alertdialog” do not have accessible names.'.

error

It would be nice if consentModal had a parameter to set this value to fix the error.

Proposed solution

No response

Additional details

No response

@basterrika basterrika added enhancement New feature or request triage yet to be reviewed labels Jun 1, 2024
@orestbida
Copy link
Owner

Fair enough.

By the way, this occurs only when you omit the title.

@orestbida orestbida removed the triage yet to be reviewed label Jun 3, 2024
@basterrika
Copy link
Author

Does this mean that the parameter will be added or that I have to settle for the title? 😅

@orestbida
Copy link
Owner

Yes, there will be a new field to handle cases like yours.

@orestbida orestbida added this to the v3.1.0 milestone Jun 5, 2024
@orestbida
Copy link
Owner

NVM, I had forgotten that there's already a consentModal.label option.

translations: {
    'en': {
        consentModal: {
            label: 'Cookie Consent Modal',
            ...
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants