Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass context and respect cancellation when calling signer server #61

Open
ronnno opened this issue Aug 7, 2019 · 0 comments
Open

pass context and respect cancellation when calling signer server #61

ronnno opened this issue Aug 7, 2019 · 0 comments

Comments

@ronnno
Copy link
Contributor

ronnno commented Aug 7, 2019

signing on blocks should be done under a context object, signer service must respect context cancellation.

additionally, we could implement defensive timeouts on LH side - not trusting signer service to respect context cancellation. @gadcl what do you think? (the question of defensive timeouts is relevant to all inter-service calls but is made especially urgent in the case of signer service because it is actually remote)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant