You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LHLogger was implemented before scribe was extracted as a standalone message.
Most of the functionality it introduces already exists in scribe (contextual tags). It adds two things that scribe does not provide today:
Dynamic field values - currently log.Stringable() does not indicate if String() is executed during WithTags and the result cached, or later, on each invocation of Info/Error.
Debug level
The proposed refactor includes removing LHLogger and replacing it with direct use of scribe:
TBD - add &1 and/or &2 to scribe after discussion (@electricmonk ?) and remove or shrink scope of LHLogger
Stop storing logger object in long lasting structs - because it ignores the contextual nature of scribe logger objects
Create a local logger object in each long lasting go-routine. enrich it with node address etc.
in each select case clause set proper entry point and contextual data for the current request
attach logger to func calls as parameters instead of relying of access to long lasting structs to promote contextual logging
The text was updated successfully, but these errors were encountered:
LHLogger was implemented before scribe was extracted as a standalone message.
Most of the functionality it introduces already exists in
scribe
(contextual tags). It adds two things thatscribe
does not provide today:log.Stringable()
does not indicate ifString()
is executed duringWithTags
and the result cached, or later, on each invocation ofInfo/Error
.The proposed refactor includes removing LHLogger and replacing it with direct use of
scribe
:scribe
after discussion (@electricmonk ?) and remove or shrink scope of LHLoggerThe text was updated successfully, but these errors were encountered: