Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass previous block timestamp to Membership.RequestOrderedCommittee #40

Open
talkol opened this issue Mar 2, 2019 · 0 comments
Open
Assignees
Labels
help wanted Extra attention is needed

Comments

@talkol
Copy link
Member

talkol commented Mar 2, 2019

We currently provide blockHeight only for getting the committee:

RequestOrderedCommittee(ctx context.Context, blockHeight primitives.BlockHeight, randomSeed uint64) []primitives.MemberId

Since the committee is now based on election results stored in state storage, we need to make a call to virtual machine to get the values

Calls to virtual machine require both block height and block timestamp

The block height is the last committed block (meaning the committee block height minus 1), but this means we need its timestamp too

If we have the header for the previous block to the committee that's ok too, the consensus context can extract the timestamp from there

@OdedWx @gadcl

@talkol talkol added the help wanted Extra attention is needed label Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants