Skip to content

Commit 2546b01

Browse files
committed
Changes to tests
1 parent 5f5fdb8 commit 2546b01

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

ojdbc-provider-observability/src/test/java/oracle/jdbc/provider/observability/ObservabilityTraceEventListenerTest.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void JFRTraceTest(boolean sensitiveDataEnabled) throws Exception {
7676
Statement statement = connection.createStatement();
7777
ResultSet resultSet = statement.executeQuery("SELECT 'OK' FROM DUAL")) {
7878
while (resultSet.next()) {
79-
System.out.println(resultSet.getString(1));
79+
assertEquals("OK", resultSet.getString(1));
8080
}
8181
}
8282
recording.stop();
@@ -140,12 +140,13 @@ public void OTELTraceTest(boolean sensitiveDataEnabled) throws Exception {
140140
Mockito.clearInvocations(tracer, spanBuilder);
141141
ObservabilityConfiguration.getInstance().setEnabledTracers("OTEL");
142142
ObservabilityConfiguration.getInstance().setSensitiveDataEnabled(sensitiveDataEnabled);
143-
try (Connection connection = DriverManager.getConnection(url, userName, password);
143+
String otelUrl = url + "?oracle.jdbc.provider.traceEventListener=observability-trace-event-listener-provider";
144+
try (Connection connection = DriverManager.getConnection(otelUrl, userName, password);
144145
Statement statement = connection.createStatement();
145146
ResultSet resultSet = statement.executeQuery("SELECT 'OK' FROM DUAL")) {
146147

147148
while (resultSet.next()) {
148-
System.out.println(resultSet.getString(1));
149+
assertEquals("OK", resultSet.getString(1));
149150
}
150151
}
151152

0 commit comments

Comments
 (0)