Skip to content

Commit 12acf18

Browse files
committed
Updated javadoc and disabled tests
1 parent cc8f9b4 commit 12acf18

File tree

6 files changed

+15
-6
lines changed

6 files changed

+15
-6
lines changed

ojdbc-provider-gcp/src/main/java/oracle/jdbc/provider/gcp/configuration/GcpConfigurationParameters.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,9 @@ public class GcpConfigurationParameters {
6363

6464
/**
6565
* @return A parser that recognizes parameters of URIs received by
66-
* {@link OciObjectStorageProvider}, and JSON objects received by
67-
* {@link GcpVaultSecretProvider}.
66+
* {@link GcpObjectStorageConfigurationProvider}, and JSON objects
67+
* received by
68+
* {@link GcpVaultSecretConfigurationProvider}.
6869
*/
6970
public static ParameterSetParser getParser() {
7071
return PARAMETER_SET_PARSER;

ojdbc-provider-gcp/src/main/java/oracle/jdbc/provider/gcp/configuration/GcpJsonVaultSecretProvider.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public class GcpJsonVaultSecretProvider implements OracleConfigurationJsonSecret
5555
* Returns the password of the Secret that is retrieved from GCP Secrets.
5656
* </p>
5757
* <p>
58-
* The {@code secretJsonObject} has the following form:
58+
* The {@code jsonObject} has the following form:
5959
* </p>
6060
*
6161
* <pre>{@code
@@ -65,14 +65,14 @@ public class GcpJsonVaultSecretProvider implements OracleConfigurationJsonSecret
6565
* }
6666
* }</pre>
6767
*
68-
* @param secretJsonObject json object to be parsed
68+
* @param jsonObject json object to be parsed
6969
* @return encoded char array in base64 format that represents the retrieved
7070
* Secret.
7171
*/
7272
@Override
73-
public char[] getSecret(OracleJsonObject oracleJsonObject) {
73+
public char[] getSecret(OracleJsonObject jsonObject) {
7474
ParameterSet parameterSet = GcpConfigurationParameters.getParser().parseNamedValues(
75-
JsonSecretUtil.toNamedValues(oracleJsonObject));
75+
JsonSecretUtil.toNamedValues(jsonObject));
7676

7777
ByteString stringData = GcpVaultSecretFactory.getInstance().request(parameterSet).getContent().getData();
7878
return Base64.getEncoder().encodeToString(stringData.toByteArray()).toCharArray();

ojdbc-provider-gcp/src/test/java/oracle/provider/gcp/configuration/GcpObjectStorageProviderTest.java

+2
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,13 @@
4242
import java.sql.SQLException;
4343
import java.util.Properties;
4444

45+
import org.junit.jupiter.api.Disabled;
4546
import org.junit.jupiter.api.Test;
4647

4748
import oracle.jdbc.provider.TestProperties;
4849
import oracle.jdbc.spi.OracleConfigurationProvider;
4950

51+
@Disabled
5052
public class GcpObjectStorageProviderTest {
5153

5254
private enum GcpTestProperties {

ojdbc-provider-gcp/src/test/java/oracle/provider/gcp/configuration/GcpVaultSecretConfigurationProviderTest.java

+2
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,13 @@
4242
import java.sql.SQLException;
4343
import java.util.Properties;
4444

45+
import org.junit.jupiter.api.Disabled;
4546
import org.junit.jupiter.api.Test;
4647

4748
import oracle.jdbc.provider.TestProperties;
4849
import oracle.jdbc.spi.OracleConfigurationProvider;
4950

51+
@Disabled
5052
public class GcpVaultSecretConfigurationProviderTest {
5153
private enum GcpTestProperties {
5254
SECRET_VERSION_NAME_CONFIG

ojdbc-provider-gcp/src/test/java/oracle/provider/gcp/resource/GcpVaultSecretPasswordProviderTest.java

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
import java.util.HashMap;
4747
import java.util.Map;
4848

49+
import org.junit.jupiter.api.Disabled;
4950
import org.junit.jupiter.api.Test;
5051

5152
import oracle.jdbc.provider.TestProperties;
@@ -54,6 +55,7 @@
5455
import static oracle.jdbc.provider.resource.ResourceProviderTestUtil.createParameterValues;
5556
import static oracle.jdbc.provider.resource.ResourceProviderTestUtil.findProvider;
5657

58+
@Disabled
5759
public class GcpVaultSecretPasswordProviderTest {
5860
private static final PasswordProvider PROVIDER = findProvider(
5961
PasswordProvider.class, "ojdbc-provider-gcp-secret-password");

ojdbc-provider-gcp/src/test/java/oracle/provider/gcp/resource/GcpVaultSecretUsernameProviderTest.java

+2
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,14 @@
4848
import java.util.HashMap;
4949
import java.util.Map;
5050

51+
import org.junit.jupiter.api.Disabled;
5152
import org.junit.jupiter.api.Test;
5253

5354
import oracle.jdbc.provider.TestProperties;
5455
import oracle.jdbc.spi.OracleResourceProvider.Parameter;
5556
import oracle.jdbc.spi.UsernameProvider;
5657

58+
@Disabled
5759
public class GcpVaultSecretUsernameProviderTest {
5860
private static final UsernameProvider PROVIDER = findProvider(
5961
UsernameProvider.class, "ojdbc-provider-gcp-secret-username");

0 commit comments

Comments
 (0)