[GR-62555] Early check for options which native image ignores.

PullRequest: graal/20259

Author: boris-spas

substratevm/src/com.oracle.svm.common/src/com/oracle/svm/common/option/IntentionallyUnsupportedOptions.java

@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2025, 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.  Oracle designates this
+ * particular file as subject to the "Classpath" exception as provided
+ * by Oracle in the LICENSE file that accompanied this code.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+package com.oracle.svm.common.option;
+
+import java.util.HashSet;
+import java.util.Set;
+
+import jdk.graal.compiler.core.common.GraalOptions;
+import jdk.graal.compiler.core.common.util.CompilationAlarm;
+import jdk.graal.compiler.hotspot.CompilerConfigurationFactory;
+import jdk.graal.compiler.options.OptionKey;
+
+/**
+ * Native image uses its own mechanisms to handle certain options, resulting in some Graal options
+ * being completely unused in native image. Being unused results in the options being silently
+ * ignored if set by the user. All such options should be listed here so that the native image
+ * options processing can reject them as unsupported.
+ */
+public final class IntentionallyUnsupportedOptions {
+
+    private static final Set<OptionKey<?>> unsupportedOptions = new HashSet<>();
+
+    static {
+        unsupportedOptions.add(CompilerConfigurationFactory.Options.CompilerConfiguration);
+        unsupportedOptions.add(GraalOptions.EagerSnippets);
+        unsupportedOptions.add(CompilationAlarm.Options.CompilationNoProgressPeriod);
+    }
+
+    private IntentionallyUnsupportedOptions() {
+        throw new IllegalStateException("Should not be initialized");
+    }
+
+    public static boolean contains(OptionKey<?> optionKey) {
+        return unsupportedOptions.contains(optionKey);
+    }
+}

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/option/SubstrateOptionsParser.java

@@ -39,6 +39,7 @@
 import com.oracle.svm.common.option.CommonOptionParser;
 import com.oracle.svm.common.option.CommonOptionParser.BooleanOptionFormat;
 import com.oracle.svm.common.option.CommonOptionParser.OptionParseResult;
+import com.oracle.svm.common.option.IntentionallyUnsupportedOptions;
 import com.oracle.svm.common.option.UnsupportedOptionClassException;
 import com.oracle.svm.core.util.InterruptImageBuilding;
 import com.oracle.svm.util.LogUtils;
@@ -90,7 +91,8 @@ public static boolean parseHostedOption(String optionPrefix, EconomicMap<String,
         if (optionParseResult.printFlags() || optionParseResult.printFlagsWithExtraHelp()) {
             SubstrateOptionsParser.printFlags(d -> {
                 OptionKey<?> key = d.getOptionKey();
-                return optionParseResult.matchesFlags(d, key instanceof RuntimeOptionKey || key instanceof HostedOptionKey);
+                return !IntentionallyUnsupportedOptions.contains(key) &&
+                                optionParseResult.matchesFlags(d, key instanceof RuntimeOptionKey || key instanceof HostedOptionKey);
             }, options, optionPrefix, out, optionParseResult.printFlagsWithExtraHelp());
             throw new InterruptImageBuilding("");
         }

substratevm/src/com.oracle.svm.driver/src/com/oracle/svm/driver/APIOptionHandler.java

@@ -48,6 +48,7 @@
 import org.graalvm.nativeimage.hosted.Feature;
 
 import com.oracle.svm.common.option.CommonOptionParser;
+import com.oracle.svm.common.option.IntentionallyUnsupportedOptions;
 import com.oracle.svm.common.option.LocatableOption;
 import com.oracle.svm.common.option.MultiOptionValue;
 import com.oracle.svm.core.SubstrateOptions;
@@ -267,7 +268,9 @@ private static void extractOption(String optionPrefix, OptionDescriptor optionDe
                                             defaultFinal, apiAnnotation.deprecated(), valueTransformers, group, apiAnnotation.extra(), apiAnnotation.launcherOption()));
         }
 
-        allOptionNames.put(optionDescriptor.getName(), new HostedOptionInfo(optionDescriptor.getStability() == OptionStability.STABLE, isBooleanOption));
+        if (!IntentionallyUnsupportedOptions.contains(optionDescriptor.getOptionKey())) {
+            allOptionNames.put(optionDescriptor.getName(), new HostedOptionInfo(optionDescriptor.getStability() == OptionStability.STABLE, isBooleanOption));
+        }
     }
 
     private static void extractPathOption(String optionPrefix, OptionDescriptor optionDescriptor, Map<String, PathsOptionInfo> pathOptions) {