[GR-63549] Fix data race between swapOut and addPredicated in the TypeFlow class

PullRequest: graal/20442

Author: d-kozak

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/PointsToAnalysis.java

@@ -650,10 +650,10 @@ public boolean finish() throws InterruptedException {
     @Override
     public void afterAnalysis() {
         /*
-         * Only verify in the context-insensitive configuration as context-sensitive analysis is not
+         * Only verify in the context-insensitive analysis because context-sensitive analysis is not
          * compatible with predicates.
          */
-        assert !PointstoOptions.AnalysisContextSensitivity.getValue(options).equals("insens") || validateFixedPointState();
+        assert analysisPolicy().isContextSensitiveAnalysis() || validateFixedPointState();
     }
 
     /**

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/flow/TypeFlow.java

@@ -955,18 +955,21 @@ private void notifySaturated(PointsToAnalysis bb) {
 
     /** This flow will swap itself out at all uses and observers. */
     protected void swapOut(PointsToAnalysis bb, TypeFlow<?> newFlow) {
+        assert isSaturated() : "This operation should only be called on saturated flows:" + this;
         for (TypeFlow<?> use : getUses()) {
             swapAtUse(bb, newFlow, use);
         }
         for (TypeFlow<?> observer : getObservers()) {
             swapAtObserver(bb, newFlow, observer);
         }
+        /*
+         * Before performing the swap, make sure addPredicated will immediately enable any newly
+         * added predicated flows.
+         */
+        AtomicUtils.atomicMark(this, PREDICATE_TRIGGERED_UPDATER);
         for (TypeFlow<?> predicatedFlow : getPredicatedFlows()) {
             swapAtPredicated(bb, newFlow, predicatedFlow);
         }
-        if (isSaturated()) {
-            AtomicUtils.atomicMark(this, PREDICATE_TRIGGERED_UPDATER);
-        }
     }
 
     protected void swapAtUse(PointsToAnalysis bb, TypeFlow<?> newFlow, TypeFlow<?> use) {