Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a Theme does not remove the theme settings. #2646

Open
leigh-pointer opened this issue Mar 7, 2023 · 4 comments
Open

Deleting a Theme does not remove the theme settings. #2646

leigh-pointer opened this issue Mar 7, 2023 · 4 comments

Comments

@leigh-pointer
Copy link
Contributor

After removing a theme from the framework the settings for the theme still remain. These should also be removed.

@sbwalker
Copy link
Member

sbwalker commented Jun 6, 2023

this is a challenge as Theme Settings are not a distinct entity type - they are stored as either Site or Page Settings (depending on the implementation within the Theme). This means there is no explicit way to identify and remove the Theme Settings as they are simply key/value pairs which do not need to follow any naming convention.

@leigh-pointer
Copy link
Contributor Author

Can we please add Themes to the Entity then? Data redundancy is not good and if a theme is deleted having a Theme entity in use to help this issue.

@sbwalker
Copy link
Member

sbwalker commented Jun 6, 2023

In Oqtane 4.0 the Theme entity is now fully supported - which means you can store Theme settings. However this does not solve the problem you are describing as these Theme settings are global in nature - much the same as ModuleDefinition settings. When applying Theme settings through the UI you are doing so in the context of a Site or Page - which means the settings should be stored in Site settings or Page settings.

@zyhfish
Copy link
Contributor

zyhfish commented Aug 18, 2024

how about to add a new property "IList SettingKeys" in the ThemeInfo class, then we can remove settings by reading this property value during uninstall process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants