Skip to content

Commit 377496e

Browse files
refactor: rename matching variation name
1 parent 1655beb commit 377496e

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/Experiment.spec.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { ReactSDKClient } from './client';
2525
import { OptimizelyVariation } from './Variation';
2626

2727
describe('<OptimizelyExperiment>', () => {
28-
const variationKey = 'variationResult';
28+
const variationKey = 'matchingVariation';
2929
let resolver: any;
3030
let optimizelyMock: ReactSDKClient;
3131
let isReady: boolean;
@@ -96,7 +96,7 @@ describe('<OptimizelyExperiment>', () => {
9696
</OptimizelyProvider>
9797
);
9898

99-
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('variationResult'));
99+
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('matchingVariation'));
100100

101101
expect(optimizelyMock.activate).toHaveBeenCalledWith('experiment1', undefined, undefined);
102102
});
@@ -150,7 +150,7 @@ describe('<OptimizelyExperiment>', () => {
150150
<OptimizelyVariation variation="otherVariation">
151151
<span data-testid="variation-key">other variation</span>
152152
</OptimizelyVariation>
153-
<OptimizelyVariation variation="variationResult">
153+
<OptimizelyVariation variation="matchingVariation">
154154
<span data-testid="variation-key">correct variation</span>
155155
</OptimizelyVariation>
156156
<OptimizelyVariation default>
@@ -203,7 +203,7 @@ describe('<OptimizelyExperiment>', () => {
203203
<OptimizelyVariation default>
204204
<span data-testid="variation-key">default variation</span>
205205
</OptimizelyVariation>
206-
<OptimizelyVariation variation="variationResult">
206+
<OptimizelyVariation variation="matchingVariation">
207207
<span data-testid="variation-key">matching variation</span>
208208
</OptimizelyVariation>
209209
</OptimizelyExperiment>
@@ -281,7 +281,7 @@ describe('<OptimizelyExperiment>', () => {
281281
<OptimizelyVariation default variation="nonMatchingVariation">
282282
<span data-testid="variation-key">default & non matching variation</span>
283283
</OptimizelyVariation>
284-
<OptimizelyVariation variation="variationResult">
284+
<OptimizelyVariation variation="matchingVariation">
285285
<span data-testid="variation-key">matching variation</span>
286286
</OptimizelyVariation>
287287
</OptimizelyExperiment>
@@ -381,7 +381,7 @@ describe('<OptimizelyExperiment>', () => {
381381

382382
expect(optimizelyMock.activate).toHaveBeenCalledWith('experiment1', 'james123', { betaUser: true });
383383

384-
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('variationResult'));
384+
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('matchingVariation'));
385385
});
386386

387387
it('should pass the values for clientReady and didTimeout', async () => {
@@ -404,7 +404,7 @@ describe('<OptimizelyExperiment>', () => {
404404
await optimizelyMock.onReady();
405405

406406
expect(optimizelyMock.activate).toHaveBeenCalledWith('experiment1', undefined, undefined);
407-
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('variationResult|true|false'));
407+
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('matchingVariation|true|false'));
408408
});
409409

410410
describe('when the onReady() promise return { success: false }', () => {
@@ -456,7 +456,7 @@ describe('<OptimizelyExperiment>', () => {
456456

457457
expect(optimizelyMock.activate).toHaveBeenCalledWith('experiment1', undefined, undefined);
458458

459-
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('variationResult'));
459+
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('matchingVariation'));
460460

461461
// capture the OPTIMIZELY_CONFIG_UPDATE function
462462
// change the return value of activate
@@ -491,7 +491,7 @@ describe('<OptimizelyExperiment>', () => {
491491
await act(async () => await optimizelyMock.onReady());
492492
expect(optimizelyMock.activate).toHaveBeenCalledWith('experiment1', undefined, undefined);
493493

494-
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('variationResult'));
494+
await waitFor(() => expect(screen.getByTestId('variation-key')).toHaveTextContent('matchingVariation'));
495495

496496
// capture the onUserUpdate function
497497
const updateFn = (optimizelyMock.onUserUpdate as jest.Mock).mock.calls[0][0];
@@ -527,7 +527,7 @@ describe('<OptimizelyExperiment>', () => {
527527
<OptimizelyVariation variation="otherVariation">
528528
<span data-testid="variation-key">other variation</span>
529529
</OptimizelyVariation>
530-
<OptimizelyVariation variation="variationResult">
530+
<OptimizelyVariation variation="matchingVariation">
531531
<span data-testid="variation-key">correct variation</span>
532532
</OptimizelyVariation>
533533
<OptimizelyVariation default>

0 commit comments

Comments
 (0)